Closed
Bug 1292917
Opened 8 years ago
Closed 8 years ago
Intermittent TEST-UNEXPECTED-TIMEOUT | dom/media/tests/mochitest/test_getUserMedia_audioCapture.html | application timed out after 330 seconds with no output after Assertion failure: mChannels && mFrames && mSampleRate (Mix not called for this cycle?)
Categories
(Core :: WebRTC, defect, P2)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla52
backlog | webrtc/webaudio+ |
People
(Reporter: intermittent-bug-filer, Assigned: pehrsons)
References
Details
(Keywords: assertion, intermittent-failure)
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
padenot
:
review+
lizzard
:
approval-mozilla-aurora+
lizzard
:
approval-mozilla-beta-
|
Details |
Filed by: philringnalda [at] gmail.com https://treeherder.mozilla.org/logviewer.html#?job_id=33455829&repo=mozilla-inbound https://queue.taskcluster.net/v1/task/ERIcFJOQSaG-Hh3RFz2RXQ/runs/0/artifacts/public%2Flogs%2Flive_backing.log
Comment 1•8 years ago
|
||
Assigning the default priority for intermittent test failure for now. Paul can you please rate how important it is that the test hits this assertion even before starting (unfortunately Paul's status prevents NI during his PTO - but nobody else from the team has even touched this file:: https://dxr.mozilla.org/mozilla-central/rev/6b65dd49d4f045c0a9753ce60bdb4b7b4aaedcf8/dom/media/AudioMixer.h#63
backlog: --- → webrtc/webaudio+
Rank: 35
Priority: -- → P3
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 4•8 years ago
|
||
Bumping priority, pretty frequent this week starting 8/22
Rank: 35 → 23
Priority: P3 → P2
Comment hidden (Intermittent Failures Robot) |
Comment 6•8 years ago
|
||
Paul see comment #1: can you please have a look and verify the rating?
Flags: needinfo?(padenot)
Comment 7•8 years ago
|
||
This means that a part of the graph thinks that we have audio flowing, whereas in fact, no audio has been written to the mixer. This can be caused by the fact that something, an audio driver is forced, even if there is no audio track. This code is becoming too complex, we should consider having a look and making it more simple. We need to touch it to fix the shutdown sequence anyways. I don't believe this is a sec issue, it simply means no audio will be output, but that it's not expected: it breaks a graph invariant, that is, if an audio driver is present, there is at least a track that wants to output audio.
Flags: needinfo?(padenot)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•8 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 16•8 years ago
|
||
I caught this one at a high failure rate recently (due to modified logging): https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2f7b93656a5 On top of that this seems like a fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0cfc1ddc844a
Assignee: nobody → pehrson
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (Intermittent Failures Robot) |
Comment 19•8 years ago
|
||
mozreview-review |
Comment on attachment 8807093 [details] Bug 1292917 - Ended tracks should still keep the AudioCaptureStream going. https://reviewboard.mozilla.org/r/90370/#review91258 Thanks!
Attachment #8807093 -
Flags: review?(padenot) → review+
Comment 20•8 years ago
|
||
Pushed by pehrsons@gmail.com: https://hg.mozilla.org/integration/autoland/rev/c6b2839bcfa8 Ended tracks should still keep the AudioCaptureStream going. r=padenot
Comment 21•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c6b2839bcfa8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment 22•8 years ago
|
||
Hi Andreas, can you please request Beta approval on this when you get a chance (for 51, assuming that this won't get approved and landed before Monday's uplift)?
Flags: needinfo?(pehrson)
Assignee | ||
Comment 23•8 years ago
|
||
Comment on attachment 8807093 [details] Bug 1292917 - Ended tracks should still keep the AudioCaptureStream going. This approval request is for 51, whichever stage it might be in. Approval Request Comment [Feature/regressing bug #]: getUserMedia tab audio capture [User impact if declined]: Intermittent assertions on try [Describe test coverage new/current, TreeHerder]: this was caught by automation [Risks and why]: Very low risk. On top of that it only affects a feature that is prefed off by default. [String/UUID change made/needed]: None
Flags: needinfo?(pehrson)
Attachment #8807093 -
Flags: approval-mozilla-beta?
Attachment #8807093 -
Flags: approval-mozilla-aurora?
Comment 24•8 years ago
|
||
Comment on attachment 8807093 [details] Bug 1292917 - Ended tracks should still keep the AudioCaptureStream going. We can get this in before the merge on Monday so this will be in place for 51 aurora.
Attachment #8807093 -
Flags: approval-mozilla-beta?
Attachment #8807093 -
Flags: approval-mozilla-beta-
Attachment #8807093 -
Flags: approval-mozilla-aurora?
Attachment #8807093 -
Flags: approval-mozilla-aurora+
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•