1293015 - Intermittent dom/media/test/test_bug879717.html | v3 (Stream of 320x240.ogv) should have gotten the 'loadeddata' event callback

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=33459285&repo=mozilla-inbound

http://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-macosx64/1470535131/mozilla-inbound_yosemite_r7_test-mochitest-media-e10s-bm106-tests1-macosx-build805.txt.gz

Comment 1

[Andreas Pehrson [:pehrsons]]

Sounds like suspected bug 1201363 fallout.

Comment 2

[Intermittent Failures Robot]

20 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 9
* autoland: 9
* try: 1
* fx-team: 1

Platform breakdown:
* linux32: 7
* osx-10-10: 6
* linux64: 4
* windows8-64: 2
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1293015&startday=2016-08-08&endday=2016-08-14&tree=all

Comment 3

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Bug 1293015 - Call mozCapturedStreamXXX in onloadedmetadata callback. .

Review commit: https://reviewboard.mozilla.org/r/71816/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/71816/

Comment 4

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8781370 [details]
Bug 1293015 - Call mozCapturedStreamXXX in onloadedmetadata callback. .

https://reviewboard.mozilla.org/r/71816/#review69370

::: dom/media/test/test_bug879717.html:123
(Diff revision 1)
>    document.body.appendChild(v2);
>    document.body.appendChild(v3);
>  
>    v1.src = media.name;
>    v2.src = media.name;
> +  v2.preload = 'metadata';

This doesn't have an effect because v2 is autoplayed.

::: dom/media/test/test_bug879717.html:125
(Diff revision 1)
> +  v2.onloadedmetadata = function () {
> -  v3.srcObject = v2.mozCaptureStreamUntilEnded();
> +    v3.srcObject = v2.mozCaptureStreamUntilEnded();
> +  };

This overwrites the old onloadedmetadata handler.

Comment 5

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 8781370 [details]
Bug 1293015 - Call mozCapturedStreamXXX in onloadedmetadata callback. .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/71816/diff/1-2/

Comment 6

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8781370 [details]
Bug 1293015 - Call mozCapturedStreamXXX in onloadedmetadata callback. .

https://reviewboard.mozilla.org/r/71816/#review70120

::: dom/media/test/test_bug879717.html:49
(Diff revision 2)
>    var v1 = document.createElement("video");
>    v1.autoplay = true;
>  
>    // Captured file playback
>    var v2 = document.createElement("video");
> -  v2.autoplay = true;
> +  v2.autoplay = false;

false is the default, so you can remove this.

::: dom/media/test/test_bug879717.html:53
(Diff revision 2)
>    var v2 = document.createElement("video");
> -  v2.autoplay = true;
> +  v2.autoplay = false;
>  
>    // Stream playback
>    var v3 = document.createElement("video");
> -  v3.autoplay = true;
> +  v3.autoplay = false;

v3 is ok to autoplay.

::: dom/media/test/test_bug879717.html:68
(Diff revision 2)
>    checkDrawImage("beforeplay", v1);
>    checkDrawImage("beforeplay", v2);
>    checkDrawImage("beforeplay", v3);
>  
>    v1.onloadedmetadata = checkDrawImageEventHandler;
> -  v2.onloadedmetadata = checkDrawImageEventHandler;
> +  v2.addEventListener('loadedmetadata', checkDrawImageEventHandler);

I think you can keep this one as the onloadedmetadata handler.

::: dom/media/test/test_bug879717.html:128
(Diff revision 2)
> +  v2.preload = 'metadata';
> +
> +  v2.addEventListener('loadedmetadata', function () {
> -  v3.srcObject = v2.mozCaptureStreamUntilEnded();
> +    v3.srcObject = v2.mozCaptureStreamUntilEnded();
> +    v2.play();
> +    v3.play();

Not needed with v3 autoplay.

::: dom/media/test/test_bug879717.html:130
(Diff revision 2)
> +  v2.addEventListener('loadedmetadata', function () {
> -  v3.srcObject = v2.mozCaptureStreamUntilEnded();
> +    v3.srcObject = v2.mozCaptureStreamUntilEnded();
> +    v2.play();
> +    v3.play();
> +  });
> +  v2.load();

With preload you don't have to load(). Or the other way around.

Comment 7

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8781370 [details]
Bug 1293015 - Call mozCapturedStreamXXX in onloadedmetadata callback. .

https://reviewboard.mozilla.org/r/71816/#review70122

Comment 8

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 8781370 [details]
Bug 1293015 - Call mozCapturedStreamXXX in onloadedmetadata callback. .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/71816/diff/2-3/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdf0c719f16d
Call mozCapturedStreamXXX in onloadedmetadata callback. r=pehrsons.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bdf0c719f16d

Comment 11

[Intermittent Failures Robot]

19 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 9
* mozilla-inbound: 8
* try: 1
* fx-team: 1

Platform breakdown:
* linux32: 8
* linux64: 6
* osx-10-10: 3
* windows8-64: 1
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1293015&startday=2016-08-15&endday=2016-08-21&tree=all

Comment 12

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

(In reply to OrangeFactor Robot from comment #11)
> 19 automation job failures were associated with this bug in the last 7 days.
> 
> Repository breakdown:
> * autoland: 9
> * mozilla-inbound: 8
> * try: 1
> * fx-team: 1
> 
> Platform breakdown:
> * linux32: 8
> * linux64: 6
> * osx-10-10: 3
> * windows8-64: 1
> * windows7-32-vm: 1
> 
> For more details, see:
> https://brasstacks.mozilla.com/orangefactor/
> ?display=Bug&bugid=1293015&startday=2016-08-15&endday=2016-08-21&tree=all

The fix seems to not yet landed on the last failure log.  
See: https://hg.mozilla.org/integration/mozilla-inbound/file/c9dcfd11f12d3dadefb846839fbc70162f592e81/dom/media/test/test_bug879717.html

Let's monitor the fix. :)