The icons of the Internet links are too small since the last update - not to see

NEW
Unassigned

Status

()

Core
Widget: Win32
P4
normal
2 years ago
2 years ago

People

(Reporter: Jutta Koliofotis, Unassigned)

Tracking

48 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: tpi:+)

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Created attachment 8778677 [details]
Desktop.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160726073904

Steps to reproduce:

I like to make a link from a website too my Desktop


Actual results:

Since a while - the icons from the links are too small with a white background


Expected results:

Previously, they they were normal sized same as whit links saved from IE

Updated

2 years ago
Group: firefox-core-security
I confirmed the small icon, compared to IE and Chrome, on Windows 7.

Shortcut created by IE and Chrome have large icon, but shortcut created by Firefox have small Icon.
I don't see any behavior difference between older versions of Firefox, so not sure why it started happening on reporter's env.


Here are the content of .lnk file, for https://www.mozilla.org/en-US/ , saved from IE 11, Chrome, and Firefox 48.0.

---- from IE11 (replaced some characters in title) ----

[{000214A0-0000-0000-C000-000000000046}]
Prop4=31,We're building a better Internet - Mozilla
Prop3=19,11
[{000214A0-0000-0000-C000-000000000046}.A]
Prop4=31,We're building a better Internet - Mozilla
[{000214A0-0000-0000-C000-000000000046}.W]
Prop4=31,We+IBk-re building a better Internet +IBQ- Mozilla
[{A7AF692E-098D-4C08-A225-D433CA835ED0}]
Prop5=3,0
Prop9=19,0
[InternetShortcut]
URL=https://www.mozilla.org/en-US/
IDList=
IconFile=https://www.mozilla.org/media/img/favicon/favicon-196x196.cb79ae3b6daf.png
IconIndex=1
[{9F4C2855-9F79-4B39-A8D0-E1D42DE1D5F3}]
Prop5=8,Microsoft.Website.A52A63AC.B83E2356

---- from Chrome ----

[InternetShortcut]
URL=https://www.mozilla.org/en-US/

---- from Firefox 48.0 ----

[InternetShortcut]
URL=https://www.mozilla.org/en-US/
IDList=
HotKey=0
IconFile=C:\Users\test\AppData\Local\Mozilla\Firefox\Profiles\rmu8hqfc.default\shortcutCache\Y7mBbbtNjUwmorbi7zYiJw==.ico
IconIndex=0

--------

So, IE is using 196x196 png favicon, referred here in the page:
>     <link rel="icon" type="image/png" sizes="196x196" href="/media/img/favicon/favicon-196x196.cb79ae3b6daf.png">

Chrome doesn't have any info, but the icon is shown somehow.

Firefox is using cached 48x48 png favicon, not sure where it comes from (maybe generated?),
but the icon looks like white background + 16x16 favicon.
Status: UNCONFIRMED → NEW
Component: Untriaged → Shell Integration
Ever confirmed: true
Created attachment 8782398 [details]
shortcut icons on Windows 7
Shell integration doesn't contain the code that does this so moving back to untriaged in the hope that this gets moved to the correct component.
Component: Shell Integration → Untriaged
thank you for checking :)

I think I located the place the icon is generated.

https://dxr.mozilla.org/mozilla-central/rev/d5f20820c80514476f596090292a5d77c4b41e3b/widget/windows/WinUtils.cpp#1315
> NS_IMETHODIMP
> AsyncFaviconDataReady::OnComplete(nsIURI *aFaviconURI,
>                                   uint32_t aDataLen,
>                                   const uint8_t *aData, 
>                                   const nsACString &aMimeType)
> {
> ...
>     // Create a 48x48 surface and paint the icon into the central 16x16 rect.
>     size.width = 48;
>     size.height = 48;
>     dataSurface =
>       Factory::CreateDataSourceSurface(size, SurfaceFormat::B8G8R8A8);
> ...
>     dt->FillRect(Rect(0, 0, size.width, size.height),
>                  ColorPattern(Color(1.0f, 1.0f, 1.0f, 1.0f)));
>     dt->DrawSurface(surface,
>                     Rect(16, 16, 16, 16),
>                     Rect(Point(0, 0),
>                          Size(surface->GetSize().width, surface->GetSize().height)));

It clearly says that we're using 48x48 image with 16x16 icon at the center.
Component: Untriaged → Widget: Win32
Product: Firefox → Core

Updated

2 years ago
Priority: -- → P4
Whiteboard: tpi:+
You need to log in before you can comment on or make changes to this bug.