Closed
Bug 1293078
Opened 9 years ago
Closed 8 years ago
Intermittent toolkit/components/passwordmgr/test/mochitest/test_formless_submit_navigation_negative.html | No formSubmissionProcessed should occur in this test
Categories
(Toolkit :: Password Manager, defect, P3)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox50 | --- | unaffected |
firefox51 | --- | fixed |
firefox52 | --- | fixed |
firefox53 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: gbrown)
References
Details
(Keywords: intermittent-failure)
Attachments
(2 files)
1.03 KB,
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
93.41 KB,
text/plain
|
Details |
Comment hidden (Intermittent Failures Robot) |
Updated•9 years ago
|
Priority: -- → P3
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 9•8 years ago
|
||
This has 45 failures on trunk in the last week and has now started failing on Aurora as well. Any chance we can bump the priority here?
Blocks: 1166947
status-firefox50:
--- → unaffected
status-firefox51:
--- → affected
status-firefox52:
--- → affected
Flags: needinfo?(MattN+bmo)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
![]() |
Assignee | |
Comment 25•8 years ago
|
||
Simply increasing the timeout seems to be effective:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=da5516b2a80bc01d660f054f6ec6a9d593d24573
vs (no change) https://treeherder.mozilla.org/#/jobs?repo=try&revision=67f11010f12bef30e5b116dc522e0e3df9aabf7c
Attachment #8812384 -
Flags: review?(MattN+bmo)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 28•8 years ago
|
||
Comment on attachment 8812384 [details] [diff] [review]
increase wait time
Review of attachment 8812384 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
::: toolkit/components/passwordmgr/test/mochitest/test_formless_submit_navigation_negative.html
@@ -102,4 @@
> info("Running " + scriptName + " script to check for a submission");
> frameDoc.defaultView.eval(SCRIPTS[scriptName]);
>
> - // Wait for 500ms to see if the promise above resolves.
Please submit future patches with more lines of context. The MDN docs recommend 8 lines before and after.
Attachment #8812384 -
Flags: review?(MattN+bmo) → review+
Updated•8 years ago
|
Assignee: nobody → gbrown
Status: NEW → ASSIGNED
Flags: needinfo?(MattN+bmo)
Updated•8 years ago
|
Keywords: checkin-needed
Comment 29•8 years ago
|
||
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/99a644129efa
Increase wait time in test_formless_submit_navigation_negative.html. r=MattN
Keywords: checkin-needed
Comment 30•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment 31•8 years ago
|
||
bugherder uplift |
Flags: in-testsuite-
Comment 32•8 years ago
|
||
bugherder uplift |
Comment 33•8 years ago
|
||
This (according to the mozregression-gui result) broke spellcheck with the hungarian dictionary for me. Though I don't see how it's relevant to it.
(Dictionary link: https://addons.mozilla.org/hu/firefox/addon/hungarian-dictionary/versions/ )
Comment 34•8 years ago
|
||
We updated Hunspell to version 1.5.0 recently, which seems much more likely.
Comment 35•8 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #34)
> We updated Hunspell to version 1.5.0 recently, which seems much more likely.
Doesn't seem like it. I did another regression test just in case. (with hungarian dictionary and hungarian text in a textbox)
And the commit of this bug came up again. I'll attach the log.
Comment hidden (Intermittent Failures Robot) |
![]() |
Assignee | |
Comment 37•8 years ago
|
||
The only affected file, test_formless_submit_navigation_negative.html, is only referenced by the test manifest, so I cannot see how the change would have any affect on spellcheck or the hungarian dictionary.
Comment 38•8 years ago
|
||
Can't help but notice that the Hunspell update is in the pushlog referenced by the log in comment 35. Please file a new bug in Core::Spelling Checker, avada. Regardless of what caused it, this isn't the right place to track your issue.
You need to log in
before you can comment on or make changes to this bug.
Description
•