Closed Bug 1293078 Opened 4 years ago Closed 4 years ago

Intermittent toolkit/components/passwordmgr/test/mochitest/test_formless_submit_navigation_negative.html | No formSubmissionProcessed should occur in this test

Categories

(Toolkit :: Password Manager, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox50 --- unaffected
firefox51 --- fixed
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: gbrown)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

This has 45 failures on trunk in the last week and has now started failing on Aurora as well. Any chance we can bump the priority here?
Blocks: 1166947
Flags: needinfo?(MattN+bmo)
Comment on attachment 8812384 [details] [diff] [review]
increase wait time

Review of attachment 8812384 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: toolkit/components/passwordmgr/test/mochitest/test_formless_submit_navigation_negative.html
@@ -102,4 @@
>        info("Running " + scriptName + " script to check for a submission");
>        frameDoc.defaultView.eval(SCRIPTS[scriptName]);
>  
> -      // Wait for 500ms to see if the promise above resolves.

Please submit future patches with more lines of context. The MDN docs recommend 8 lines before and after.
Attachment #8812384 - Flags: review?(MattN+bmo) → review+
Assignee: nobody → gbrown
Status: NEW → ASSIGNED
Flags: needinfo?(MattN+bmo)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/99a644129efa
Increase wait time in test_formless_submit_navigation_negative.html. r=MattN
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/99a644129efa
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
This (according to the mozregression-gui result) broke spellcheck with the hungarian dictionary for me. Though I don't see how it's relevant to it.

(Dictionary link: https://addons.mozilla.org/hu/firefox/addon/hungarian-dictionary/versions/ )
We updated Hunspell to version 1.5.0 recently, which seems much more likely.
Attached file dict-bug.txt
(In reply to Ryan VanderMeulen [:RyanVM] from comment #34)
> We updated Hunspell to version 1.5.0 recently, which seems much more likely.

Doesn't seem like it. I did another regression test just in case. (with hungarian dictionary and hungarian text in a textbox)
And the commit of this bug came up again. I'll attach the log.
The only affected file, test_formless_submit_navigation_negative.html, is only referenced by the test manifest, so I cannot see how the change would have any affect on spellcheck or the hungarian dictionary.
Can't help but notice that the Hunspell update is in the pushlog referenced by the log in comment 35. Please file a new bug in Core::Spelling Checker, avada. Regardless of what caused it, this isn't the right place to track your issue.
You need to log in before you can comment on or make changes to this bug.