Closed Bug 129315 Opened 20 years ago Closed 18 years ago

incorrect column definition for bugs.delta_ts

Categories

(Bugzilla :: Bugzilla-General, defect, P3)

2.15
defect

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: myk, Assigned: goobix)

Details

Attachments

(1 file)

The bugs.delta_ts field is defined as being able to contain NULL values, even
though it is initialized to the current date/time when a new record is created
in that table and is never set to NULL.  It should be defined as *not* being
able to contain NULL values.
Priority: -- → P3
Target Milestone: --- → Bugzilla 2.18
Attachment #131629 - Flags: review?(kiko)
This patch does not modify the structure of an existing table, I think it
affects only new tables created by checksetup. Modifying the existing ones too
might be overkill and I don't know if that would be needed as well.
Yeah, we can fix old systems when we change it from TIMESTAMP to DATETIME
Comment on attachment 131629 [details] [diff] [review]
Patch to make delta_ts not null

I agree that it's not important to change existing tables, and justdave
confirmed, so r=kiko.
Attachment #131629 - Flags: review?(kiko) → review+
Reassigning to patch writer.
Assignee: justdave → jocuri
Flags: approval?
Status: NEW → ASSIGNED
Flags: approval? → approval+
Checked in:

/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.251; previous revision: 1.250

(And vladd chalks another one off!)
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.