1293194 - Building with --disable-eme fails with GMPDecoderModule.cpp:15:30: fatal error: mozilla/EMEUtils.h: No such file or directory

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect, P1)

Comment 1

[Mike Hommey [:glandium]]

Relatedly, there is also this error with --disable-eme:
In file included from $srcdir/dom/media/gmp/GMPCDMCallbackProxy.cpp:7:0,
                 from $objdir/dom/media/gmp/Unified_cpp_dom_media_gmp0.cpp:29:
$srcdir/dom/media/gmp/GMPCDMCallbackProxy.h:10:30: fatal error: mozilla/CDMProxy.h: No such file or directory

Comment 2

[James Cheng[:JamesCheng]]

I will try to fix it.

Comment 3

[James Cheng[:JamesCheng]]

Hi glandium,

I want to reproduce this issue locally but meet a build error.

I set |ac_add_options --disable-eme| in my mozconfig file and ./mach build

The error is

WebIDL.WebIDLError: error: Unresolved type '<unresolved scope>::MediaKeys'., /media/hdd/Projects/gecko-mozilla2/obj-x86_64-pc-linux-gnu/dom/bindings/HTMLMediaElement.webidl line 161:21
 0:56.81   readonly attribute MediaKeys? mediaKeys;

But this attribute is protected by [1], I don't know why I met this issue...

I think --disable-eme is something about the macro MOZ_EME but I don't know the relations between

--enable-xxx and --disable-xxx.

I guess it is related to [2]

Could you please help me to clarify this symptom?

Thank you!

[1] https://dxr.mozilla.org/mozilla-central/rev/e78975b53563d80c99ebfbdf8a9fbf6b829a8a48/dom/webidl/HTMLMediaElement.webidl#158

[2] https://dxr.mozilla.org/mozilla-central/rev/e78975b53563d80c99ebfbdf8a9fbf6b829a8a48/toolkit/moz.configure#370

Comment 4

[James Cheng[:JamesCheng]]

Hi glandium,

I tried

./mach configure --> no use.

./mach build-backend --> no use.

Eventually,
./mach clobber is OK to fix comment3

I would like to know what is the best way to deal with this situation.

Thank you.

Comment 5

[James Cheng[:JamesCheng]]

Attachment: Bug 1293194 - Building with --disable-eme fails with GMPDecoderModule.cpp:15:30: fatal error: mozilla/EMEUtils.h: No such file or directory.

Review commit: https://reviewboard.mozilla.org/r/70216/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70216/

Comment 6

[James Cheng[:JamesCheng]]

Comment on attachment 8779181 [details]
Bug 1293194 - Building with --disable-eme fails with GMPDecoderModule.cpp:15:30: fatal error: mozilla/EMEUtils.h: No such file or directory.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/70216/diff/1-2/

Comment 7

[James Cheng[:JamesCheng]]

Hi Chris,

I ignore to consider the EME disabled case so this patch is trying to fix those build fail.

I create a MediaCommon.h that is intended to centralize lots of "preference string", "common usage string" or any other common types to this file.

Please review this patch, 

Thank you very much.

Comment 8

[James Cheng[:JamesCheng]]

Comment on attachment 8779181 [details]
Bug 1293194 - Building with --disable-eme fails with GMPDecoderModule.cpp:15:30: fatal error: mozilla/EMEUtils.h: No such file or directory.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/70216/diff/2-3/

Comment 9

[Mike Hommey [:glandium]]

(In reply to James Cheng[:JamesCheng] from comment #4)
> Hi glandium,
> 
> I tried
> 
> ./mach configure --> no use.
> 
> ./mach build-backend --> no use.
> 
> Eventually,
> ./mach clobber is OK to fix comment3
> 
> I would like to know what is the best way to deal with this situation.
> 
> Thank you.

Some kinds of changes to mozconfig can require a clobber, that's the sad state of our build system, unfortunately.

Comment 10

[James Cheng[:JamesCheng]]

Attach treeherder result to ensure the build success.

Build with --disable-eme
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0fbf85a4b33b

Build without --disable-eme
https://treeherder.mozilla.org/#/jobs?repo=try&revision=72189dcd0599&selectedJob=25354903

Comment 11

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8779181 [details]
Bug 1293194 - Building with --disable-eme fails with GMPDecoderModule.cpp:15:30: fatal error: mozilla/EMEUtils.h: No such file or directory.

https://reviewboard.mozilla.org/r/70216/#review67918

::: dom/media/MediaCommon.h:13
(Diff revision 3)
> +#define MeidaCommon_h_
> +
> +namespace mozilla {
> +  namespace {
> +    // EME Key System String.
> +    const char* const kEMEKeySystemClearkey = "org.w3.clearkey";

How about just putting these in VideoUtils.h?

Comment 12

[James Cheng[:JamesCheng]]

Thanks for reviewing.

I will put those into VideoUtils.h

Thank you.

Comment 13

[James Cheng[:JamesCheng]]

Comment on attachment 8779181 [details]
Bug 1293194 - Building with --disable-eme fails with GMPDecoderModule.cpp:15:30: fatal error: mozilla/EMEUtils.h: No such file or directory.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/70216/diff/3-4/

Comment 14

[James Cheng[:JamesCheng]]

carry r+ and move into VideoUtils.h

Thanks

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/59e4fc48a9b4
Building with --disable-eme fails with GMPDecoderModule.cpp:15:30: fatal error: mozilla/EMEUtils.h: No such file or directory. r=cpearce

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/59e4fc48a9b4

Comment 17

[kevink9876543]

This bug also affects beta.  Could you please uplift the fix?

Thanks

Comment 18

[James Cheng[:JamesCheng]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8da216bf836

Comment 19

[James Cheng[:JamesCheng]]

Comment on attachment 8779181 [details]
Bug 1293194 - Building with --disable-eme fails with GMPDecoderModule.cpp:15:30: fatal error: mozilla/EMEUtils.h: No such file or directory.

Approval Request Comment
[Feature/regressing bug #]:Bug 1284809, Bug 1288320 
[User impact if declined]:NA
[Describe test coverage new/current, TreeHerder]:NA
[Risks and why]: 
If --disable-eme to build aurora, it will build fail without this patch.
So this patch is to fix the build fail on Aurora.

Comment 20

[James Cheng[:JamesCheng]]

Attach treeherder result to ensure build OK for Aurora.

enable-eme
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a55ccb59ab43

--disable-eme
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b8996c98fd88

Comment 21

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8779181 [details]
Bug 1293194 - Building with --disable-eme fails with GMPDecoderModule.cpp:15:30: fatal error: mozilla/EMEUtils.h: No such file or directory.

Makes sense, Aurora50+

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/afbb4f8032df

Comment 23

[kevink9876543]

My apologies, I was confused by a series of coincidences.
The build failure of beta 49 with --disable-eme is different and unrelated to this bug.