1293206 - Intermittent dom/media/tests/mochitest/test_peerConnection_basicAudioNATRelay.html | application crashed [@ libc-2.23.so + 0x35418]

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: tomcat [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=3223377&repo=mozilla-aurora

https://queue.taskcluster.net/v1/task/bacPNsF3S9yGmdjA1dBpjw/runs/0/artifacts/public%2Flogs%2Flive_backing.log

Comment 1

[Byron Campen [:bwc]]

With just a quick glance, I'm not seeing why that assert would fail:

static void nr_socket_buffered_stun_connected_cb(NR_SOCKET s, int how, void *arg)
{
  nr_socket_buffered_stun *sock = (nr_socket_buffered_stun *)arg;
  int r, _status;

  assert(!sock->connected);

Comment 2

[Nils Ohlmeier [:drno]]

(In reply to Byron Campen [:bwc] from comment #1)
> With just a quick glance, I'm not seeing why that assert would fail:

My only explanation for that would be that we get multiple callbacks for connected. Obviously as we haven't this before my patch in bug 1290365 is the most likely culprit.

Comment 3

[Nils Ohlmeier [:drno]]

Attachment: Bug 1293206: cancel TCP connect callback after connect.

Review commit: https://reviewboard.mozilla.org/r/70532/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70532/

Comment 4

[Byron Campen [:bwc]]

Comment on attachment 8779562 [details]
Bug 1293206: cancel TCP connect callback after connect.

https://reviewboard.mozilla.org/r/70532/#review68012

Comment 5

[Nils Ohlmeier [:drno]]

check back on the treeherder result.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30c27c9a8365
cancel TCP connect callback after connect. r=bwc

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/30c27c9a8365

Comment 8

[Intermittent Failures Robot]

26 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-aurora: 15
* mozilla-beta: 11

Platform breakdown:
* linux64: 16
* linux32: 10

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1293206&startday=2016-08-08&endday=2016-08-14&tree=all

Comment 9

[Nils Ohlmeier [:drno]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=63370e824a65

Comment 10

[Nils Ohlmeier [:drno]]

Attachment: bug1293206_aurora.patch

Same patch as the original on which landed in 51, just adapted to 50 and 49, so we can request uplift to unblock uplifting of bug 1290365.

Comment 11

[Nils Ohlmeier [:drno]]

Comment on attachment 8781185 [details] [diff] [review]
bug1293206_aurora.patch

Approval Request Comment
[Feature/regressing bug #]: The original bug 891551 which added support for TCP ICE candidates already had the problem that the code relied on pending data for the TCP connection to replace the connect callback with the write callback. But we did not have proper testing which exposed the problem.

[User impact if declined]: The user impact of the wrong behavior is not really know, but this patch blocks the landing/uplifting for bug 1290365, which results in a small percentage of WebRTC users not being able to place successful calls when it should be possible for them.

[Describe test coverage new/current, TreeHerder]: The patch itself make our existing test work properly, so no additional test coverage needed.

[Risks and why]: The risk should be small as the same pattern of first canceling the callback before setting it again is already successfully used in several other place in the nICEr code base.

[String/UUID change made/needed]: N/A

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8781185 [details] [diff] [review]
bug1293206_aurora.patch

Has stabilized on Nightly51 for a few days, fixes an intermittent, worth uplifting to Aurora50.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/46e19362c2ba

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8781185 [details] [diff] [review]
bug1293206_aurora.patch

Should be helpful for WebRTC, let's take it on beta 5

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/18420a62cca8