129329 - xml-rpc interface embeds additional Carriage Return & Line Feed's in RPC Request Body

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[James Warner]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.7+)
Gecko/20020116
BuildID:    20020307

In generating the XmlRpc Msg Request.  An additional Carriage Return & Line Feed
('\r\n') is appended to the http header before the Xml Msg Body. After end of
the http header instead of seeing 2 Carriage return/Line Feed combinations a
third Carriage return/Line Feed combination is present.  Also in between  the
"<?xml version ="1.0" encoding="ISO-8859-1"?>" and the "<methodCall>" an
additional line feed is added.  This is creating an interoperability problem
with the xmlrpc-c library implementation.  However, using other XmlRpc libraries
it doesn't seem to be an issue 

Reproducible: Always
Steps to Reproduce:
1.Start Up A Network Listener  to print out the XML Request Stream
2.Initialize an xmlrpc object and send an XmlRpc Message
3.Examine the Xml Stream that is printed by the Network Listener

Actual Results:  The output data should be printed without 3 CR\LF combos after
the HTTP Header and No additional line feed should be present inbetween the <?xml> 
and <methodCall> fields.

Expected Results:  The CR\LF and LF should not be present in the output Message
Request Stream.

Pending other reason's for not fixing it the following should fix nsXmlRpcClient.js
remove the '\n' from the below line in function XMLWriter():
this.data = '<?xml version="1.0" encoding="ISO-8859-1"?>\n';

Inside of the _getChannel function remove the request="\r\n" + request; line

Comment 1

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Samuel Sieb is the module owner of XML-RPC, reassigning.

Comment 2

[Samuel Sieb]

The extra cr/nl after the header should have been fixed a while ago.  I'll take
a look again.
What's wrong with there being a blank line after the <?xml ?> tag?  Isn't that
valid?

Comment 3

[James Warner]

Ok, 
My Apologies on the first one I checked the newest version in CVS and it has in
fact been removed from the _getChannel function.

As for the '\n' being valid in the XMLWriter() function.  I can't say if it is
speced in the XMLRPC specification document, but two other implementations the
Apache XmlRpc implementation in java and the xmlrpc-c library do not produce the
 additional '\n' in this spot.  This in fact does prevent a server implemented
in xmlrpc-c from processing a request from a mozilla client.  To be fair however
the ApacheXmlRpc implementation process's that request correctly.  For maximum
portability it would seem to be good to leave the '\n' out of the request.

Comment 4

[Heikki Toivonen (remove -bugzilla when emailing directly)]

XML itself allows whitespace after the XML declaration, but if there is a
service that has a bug and cannot handle it, I think it would be nice for us to
not add the newline there. It is still valid XML, just not as nice to read for
humans. But then again, this is being read by a machine so who cares...

Comment 5

[Samuel Sieb]

Attachment: remove newline

Comment 6

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Comment on attachment 72912 [details] [diff] [review]
remove newline

r=heikki

Comment 7

[Darin Fisher]

Comment on attachment 72912 [details] [diff] [review]
remove newline

rs=darin

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 72912 [details] [diff] [review]
remove newline

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 9

[Samuel Sieb]

checked in to trunk