Upgrade Firefox 51 to NSPR 4.13

RESOLVED FIXED in Firefox 51

Status

defect
RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: kaie, Unassigned)

Tracking

51 Branch
mozilla51

Firefox Tracking Flags

(firefox51 fixed, firefox52 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
We should create a NSPR release during the current mozilla-central Firefox 51 cycle.
(Reporter)

Comment 1

3 years ago
Ted or Mike, can I use r=you for uplifting the NSPR beta into m-c 51, and if we don't get any problems, again for a final RTM later?

Because of the next branch merge scheduled for September 12, and because of personal schedule and a busy September, I'd prefer to tag the NSPR 4.13 early, on August 25.

Would that work for you? Are you aware of any NSPR changes that should go into Firefox 51?

Thanks
Flags: needinfo?(ted)
(Reporter)

Updated

3 years ago
Flags: needinfo?(mh+mozilla)
Considering I just found bug 1295056, I'd rather have that in the next release. Hopefully, wtc should be able to review that quickly.
Flags: needinfo?(mh+mozilla)
I'm fine with tagging and releasing NSPR 4.13. I wouldn't hold it for glandium's patch, but if he gets it reviewed and landed, great. You can use r=me for landing.
Flags: needinfo?(ted)
(Reporter)

Updated

3 years ago
Target Milestone: --- → mozilla51
(Reporter)

Comment 4

3 years ago
I've submitted a try build with NSPR_4_13_BETA2
https://treeherder.mozilla.org/#/jobs?repo=try&revision=326a50112798

I should be able to land it prior to Monday, but if I fail to do that, please feel free to help out by landing it (python client.py update NSPR_4_13_BETA2; hg addremove), and r=ted
(Reporter)

Updated

3 years ago
Keywords: leave-open
(Reporter)

Comment 5

3 years ago
(In reply to Kai Engert (:kaie) from comment #4)
> I should be able to land it prior to Monday

done:
https://hg.mozilla.org/integration/mozilla-inbound/rev/23ecdb879a8b
(Reporter)

Comment 8

3 years ago
Landed a beta3 to pull in the fix for bug 1289145

We should wait one week, until we declare this NSPR release as final.

(This will require a version tag adjustments during aurora.)
Depends on: 1289145
(Reporter)

Comment 10

3 years ago
reusing r=ted for the version upgrade

No code change, only version number changes and checks.

This must be uplifted to aurora 51, because it currently uses a beta snapshot of NSPR, and we are required to ship RTM versions.
Attachment #8794894 - Flags: review+
Attachment #8794894 - Flags: approval-mozilla-aurora?
(Reporter)

Updated

3 years ago
Keywords: leave-open

Comment 11

3 years ago
Pushed by kaie@kuix.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a31fd577c38a
Upgrade Firefox 51 to NSPR 4.13, finalizing version numbers, no code change, reusing r=ted
Comment on attachment 8794894 [details] [diff] [review]
finalize version numbers

NSS update, Aurora51+
Attachment #8794894 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 14

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a31fd577c38a
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.