1293329 - Upgrade Firefox 51 to NSPR 4.13

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Kai Engert [:KaiE:]]

We should create a NSPR release during the current mozilla-central Firefox 51 cycle.

Comment 1

[Kai Engert [:KaiE:]]

Ted or Mike, can I use r=you for uplifting the NSPR beta into m-c 51, and if we don't get any problems, again for a final RTM later?

Because of the next branch merge scheduled for September 12, and because of personal schedule and a busy September, I'd prefer to tag the NSPR 4.13 early, on August 25.

Would that work for you? Are you aware of any NSPR changes that should go into Firefox 51?

Thanks

Comment 2

[Mike Hommey [:glandium]]

Considering I just found bug 1295056, I'd rather have that in the next release. Hopefully, wtc should be able to review that quickly.

Comment 3

[(not currently active) Ted Mielczarek]

I'm fine with tagging and releasing NSPR 4.13. I wouldn't hold it for glandium's patch, but if he gets it reviewed and landed, great. You can use r=me for landing.

Comment 4

[Kai Engert [:KaiE:]]

I've submitted a try build with NSPR_4_13_BETA2
https://treeherder.mozilla.org/#/jobs?repo=try&revision=326a50112798

I should be able to land it prior to Monday, but if I fail to do that, please feel free to help out by landing it (python client.py update NSPR_4_13_BETA2; hg addremove), and r=ted

Comment 5

[Kai Engert [:KaiE:]]

(In reply to Kai Engert (:kaie) from comment #4)
> I should be able to land it prior to Monday

done:
https://hg.mozilla.org/integration/mozilla-inbound/rev/23ecdb879a8b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/23ecdb879a8b

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/13e09cb5ffe9
NSPR_4_13_BETA3, reusing r=ted

Comment 8

[Kai Engert [:KaiE:]]

Landed a beta3 to pull in the fix for bug 1289145

We should wait one week, until we declare this NSPR release as final.

(This will require a version tag adjustments during aurora.)

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/13e09cb5ffe9

Comment 10

[Kai Engert [:KaiE:]]

Attachment: finalize version numbers

reusing r=ted for the version upgrade

No code change, only version number changes and checks.

This must be uplifted to aurora 51, because it currently uses a beta snapshot of NSPR, and we are required to ship RTM versions.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a31fd577c38a
Upgrade Firefox 51 to NSPR 4.13, finalizing version numbers, no code change, reusing r=ted

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8794894 [details] [diff] [review]
finalize version numbers

NSS update, Aurora51+

Comment 13

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1795346935ff752add935af6f082bef916d12706

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a31fd577c38a