1293355 - fromCache is absent from onResponseStarted callback

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, defect, P2)

Description

[Jon Wiles]

Attachment: fromcache.zip

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160630070928

Steps to reproduce:

1. Load the attached extension.
2. Browse the web.



Actual results:

Notice that fromCache is always undefined.


Expected results:

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/WebRequest/onResponseStarted says fromCache should be set.

Comment 1

[Tomislav Jovanovic :zombie]

From my investigation, it seems that nsIHttpChannel doesn't have any property or method that would indicate if the response came from the cache (nor can it be QIed to something like nsICachedChannel to check).

The way to distinguish cached vs uncached responses is in WebRequest.jsm when we first observe them:

http://searchfox.org/mozilla-central/source/toolkit/modules/addons/WebRequest.jsm#426

Or did I miss something?

Comment 2

[Kris Maglione [:kmag]]

I think we just need to check whether we're examining the response from an http-on-examine-response observer vs. an http-on-examine-cached-response or http-on-examine-merged-response observer.

Comment 3

[Tomislav Jovanovic :zombie]

> I think we just need to check whether we're examining the response from an
> http-on-examine-response observer vs. an http-on-examine-cached-response or

I thought I was saying just that.. ;)

Comment 4

[Tomislav Jovanovic :zombie]

Attachment: bug 1293355 - add fromCache to onResponseStarted details,

Review commit: https://reviewboard.mozilla.org/r/80198/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80198/

Comment 5

[Kris Maglione [:kmag]]

Comment on attachment 8793469 [details]
bug 1293355 - add fromCache to onResponseStarted details,

https://reviewboard.mozilla.org/r/80198/#review80124

Thanks!

::: toolkit/components/extensions/test/mochitest/test_ext_webrequest.html:429
(Diff revision 1)
> +  function checkFromCache(kind, details) {
> +    if (checkCompleted) {
> +      // If we have already completed a GET request for this url,
> +      // and it was found, we expect for the response to come fromCache.
> +      const completed = (kind in completedUrls) && completedUrls[kind].has(details.url);
> +      const expected = completed && (details.method === "GET") && (details.statusCode != 404);

No parens, please.

Comment 6

[Tomislav Jovanovic :zombie]

Comment on attachment 8793469 [details]
bug 1293355 - add fromCache to onResponseStarted details,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/80198/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aeedc4a1f893
add fromCache to onResponseStarted details, r=kmag

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/aeedc4a1f893