Closed
Bug 1293364
Opened 8 years ago
Closed 8 years ago
Factor out duplicate xpidl typedefs from netwerk
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: nika, Assigned: nika)
References
Details
(Whiteboard: [necko-active])
Attachments
(1 file, 1 obsolete file)
|
4.12 KB,
patch
|
mayhemer
:
review+
|
Details | Diff | Splinter Review |
The rust bindings for xpcom being implemented in bug 1293362 require that no duplicate typedefs occur within idl files. All instances of these duplicate typedefs are found in netwerk. This patch removes these duplicate typedefs.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8779011 -
Flags: review?(honzab.moz)
|
||
Updated•8 years ago
|
Whiteboard: [necko-active]
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8779011 [details] [diff] [review] Refactor out duplicate typedefs in xpidl Review of attachment 8779011 [details] [diff] [review]: ----------------------------------------------------------------- I'd rather move typedef unsigned long nsLoadFlags; to nsIRequest.idl where it logically belongs IMO.
Attachment #8779011 -
Flags: review?(honzab.moz) → review-
|
|
Assignee | |
Comment 3•8 years ago
|
||
Attachment #8779445 -
Flags: review?(honzab.moz)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8779011 -
Attachment is obsolete: true
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8779445 [details] [diff] [review] Refactor out duplicate typedefs in xpidl Review of attachment 8779445 [details] [diff] [review]: ----------------------------------------------------------------- thanks!
Attachment #8779445 -
Flags: review?(honzab.moz) → review+
Pushed by michael@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e421ca6968b2 Refactor out duplicate typedefs in xpidl, r=mayhemer
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e421ca6968b2
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•