Closed
Bug 1293419
Opened 5 years ago
Closed 5 years ago
Make the trace logger use js::Thread instead of PRThread
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file, 1 obsolete file)
6.52 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
This also introduces a hasher for js::Thread::Id.
Assignee | ||
Comment 1•5 years ago
|
||
This also introduces a hasher for js::Thread::Id which could certainly use a good double checking. I wasn't totally sure which parts of the Id are actually unique and/or belong in the hash.
Attachment #8779066 -
Flags: review?(terrence)
Assignee | ||
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Comment on attachment 8779066 [details] [diff] [review] Make the trace logger use js::Thread instead of PRThread Review of attachment 8779066 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/threading/Thread.h @@ +83,5 @@ > + } > + > + static void rekey(Id& key, const Id& newKey) { > + key = newKey; > + } Please remove |rekey|. It should not be instantiated unless you try to actually use rekeying and we *really* want the compile to fail if you think you need to change a Thread's id. ::: js/src/threading/posix/Thread.cpp @@ +39,5 @@ > > +/* static */ js::HashNumber > +js::Thread::Hasher::hash(const Lookup& l) > +{ > + return mozilla::HashBytes(l.platformData()->ptThread, sizeof(pthread_t)); |ptThread| is a pthread_t, so you'll need an & in front of it to call HashBytes.
Attachment #8779066 -
Flags: review?(terrence) → review+
Assignee | ||
Updated•5 years ago
|
Attachment #8779066 -
Attachment is obsolete: true
Assignee | ||
Comment 4•5 years ago
|
||
Try push for this and others: https://treeherder.mozilla.org/#/jobs?repo=try&revision=97ba2ddf4876
Pushed by nfitzgerald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5bf671f59015 Make the trace logger use js::Thread instead of PRThread; r=terrence
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5bf671f59015
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•