1293426 - Give TPS a configurable option to point at a non-production Sync server

Status: VERIFIED FIXED

(Firefox :: Sync, defect, P2)

Description

[Karl Thiessen [:kthiessen, he/him]]

This is necessary for bug 1219456 -- the intensive TPS job should run somewhere where it won't interfere with production services.

Thom and Mark, please feel free to email or comment with any questions/caveats, etc.

Thanks.

Comment 1

[Thom Chiovoloni [:tcsc] (ex-moco)]

Attachment: Bug 1293426 - Allow TPS config to specify preference values so it can be pointed at non-production servers

Review commit: https://reviewboard.mozilla.org/r/70936/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70936/

Comment 2

[Thom Chiovoloni [:tcsc] (ex-moco)]

Ended up doing this sooner rather than later so that I could test my work on bug 1253051. Basically, just looks for stuff like `"preferences": { "foo.bar.baz": "asdf", ... }` and merges them into the preferences it would start Firefox with. This definitely allows syncing with stage if you specify all the right prefs (this is a bit unwieldy, admittedly).

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8780189 [details]
Bug 1293426 - Allow TPS config to specify preference values so it can be pointed at non-production servers

https://reviewboard.mozilla.org/r/70936/#review68584

LGTM, thanks. Can you please update the bug with instructions for Karl to follow on how to specify the prefs that point this at stage (ie, the specific values he should add, and where he should specify them)

Comment 4

[Thom Chiovoloni [:tcsc] (ex-moco)]

Karl: https://pastebin.mozilla.org/8891597 is my TPS config (sans user/pass). I believe only lines 17 to 28 are relevant but it seemed better to paste the whole thing. This is the file located at `<tps-venv-root>/config.json`.  This probably goes without saying, but you will need to register the account on stage for this to work.

Some of these values are probably superfluous (For example, I can't imagine TPS needs the signup URI to work), but they don't do any harm and it was easier for me to specify them all than to find the relevant subset.

Let me know if you have any issues.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c7b15b477ed
Allow TPS config to specify preference values so it can be pointed at non-production servers r=markh

Comment 6

[Mark Hammond [:markh] [:mhammond]]

Hey Karl,
  Please see comment 4 - can you please re-enable TPS on stage?

Comment 7

[Karl Thiessen [:kthiessen, he/him]]

I will set up a job for Stage sometime today PDT.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2c7b15b477ed

Comment 9

[Karl Thiessen [:kthiessen, he/him]]

This got shuffled back behind some high-priority options; I'll give it another stab this week.

Comment 10

[Karl Thiessen [:kthiessen, he/him]]

This is verified; Thom is using it regularly.  And as soon as :rpapa and I figure out where to put it, we'll get it running on a schedule.  See bug 1219456 for details.