Closed Bug 1293452 Opened 7 years ago Closed 7 years ago

browser_ext_browserAction_popup_resize.js calls ok() with three arguments, should be calling is()

Categories

(WebExtensions :: Untriaged, defect)

Product:
WebExtensions
Component:
Untriaged
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jaws, Unassigned)

References

Details

At
http://searchfox.org/mozilla-central/rev/5b35b60ada19621c84ecab78998416d8b86a8254/browser/components/extensions/test/browser/browser_ext_browserAction_popup_resize.js#180
and 
http://searchfox.org/mozilla-central/rev/5b35b60ada19621c84ecab78998416d8b86a8254/browser/components/extensions/test/browser/browser_ext_browserAction_popup_resize.js#187

is() should be called instead of ok(), though replacing ok() with is() fails because the first argument is a fractional number whereas the second argument is an integer. If we Math.floor() the first argument then the test will pass.
Fixed by bug 1252224.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.