1293458 - Extend `Bookmarks.fetch` to allow a `parentGuid` without an `index`

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P3)

Description

[Lina Cambridge [:lina] (ex-Mozilla)]

Specifying a parent without an index would fetch all of a parent's children, sorted by the index. (Suggestion from bug bug 1274108, comment 59).

Comment 1

[Mike Kaply [:mkaply]]

Shouldn't this just be removing this line:

https://searchfox.org/mozilla-central/rev/a3b25e347e2c22207c4b369b99246e4aebf861a7/toolkit/components/places/Bookmarks.jsm#1508

All of the queries in the file already take parentGuid into account when doing their queries.

Comment 2

[Marco Bonardo [:mak]]

(In reply to Mike Kaply [:mkaply] from comment #1)

Shouldn't this just be removing this line:

https://searchfox.org/mozilla-central/rev/a3b25e347e2c22207c4b369b99246e4aebf861a7/toolkit/components/places/Bookmarks.jsm#1508

Yes, with a test checking that the default value works (likely it needs a "defaultValue: this.DEFAULT_INDEX," instead of "requiredIf")

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Bug 1293458 - Allow for fetching children of a parentGuid. r?Standard8!

Comment 4

[Mike Kaply [:mkaply]]

Posted before your comment. I'll make the additional changes.

Comment 5

[Marco Bonardo [:mak]]

also, I'm not sure it's just going to work because it seems comment 0 is requesting a behavior change, so fetching without an index fetches all the children... currently with parent and index it only fetches one... As I said I can't check atm due to lack of time left (sorry).

we have await fetchBookmarkByPosition(fetchInfo, options); this seems to require the addition of a fetchBookmarksByParent similar to fetchBookmarksByURL

Comment 6

[Mike Kaply [:mkaply]]

Yeah, this is way more complicated then it looks. It looks like you can't combine various fetch items at all. So if you specify a GUIDPrefix, you can't use Tags for instance.

So my use case - specifying a GUID prefix and a parentGUID wouldn't even work.

But Lina's use case is pretty straightforward, so I can still do a patch for that.

Comment 7

[Mike Kaply [:mkaply]]

Attachment: Bug 1293458 - Add the ability to fetch bookmarks by parent GUID. r?Standard8!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6bcdb42ce67
Add the ability to fetch bookmarks by parent GUID. r=Standard8

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a6bcdb42ce67