1293468 - Get CI working in buddyBuild

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect, P1)

Description

[Farhan Patel [:farhan]]

I've been working on getting CI setup on buddybuild. So far it's been pretty seamless. The app builds and runs tests without any configuration. However one of our tests is currently timing out. The team over at buddybuild is figuring this out now. 

After that we should be ready to turn on the CI for everyone.

Comment 1

[Farhan Patel [:farhan]]

Attachment: Pull Request

Comment 2

[Farhan Patel [:farhan]]

master 7bbb5465571eace354212d163fdcb00e71b3d057

Comment 3

[Farhan Patel [:farhan]]

All the necessary code changes have been made. But I'm going to leave this open till I get everything set up on the buddybuild side

Comment 4

[Farhan Patel [:farhan]]

Lots of work has been done! And with the move to firefox-mobile. Its been a lot easier. There is still a little bit of work left though!

- Tests arent running right now because compiling any scheme that doesnt use the FennecAurora build configuration breaks the build when CI tries to run (It tries to codesign but fails). The upside of code signing every build is that any build thats compiled is ready to be deployed with a few clicks. Move the FennecCI / FennecUnitTest schemes to use the FennecAurora configuration as well. 
- I'd like to get Danger https://danger.systems/ working. Right now swiftlint runs. But unless you look at travis you dont see linting errors. Danger can leave a comment in the PR letting you know where the linting errors are. There is more we can do but thats all I want for now. This is pretty simple to setup in BB.
- The UI on the BB website loads very slowly (I think) because we have way too many branches. Lets try to prune branches we don't use anymore.

Stefan / Emily / James / Steph / Richard If it isn't too big of a hassle could you guys please remove any open branches that you know are not useful. I think we can easily remove all the closed/merged branches.

Comment 5

[Stephan Leroux [:sleroux]]

I've deleted merged/closed branches that are no longer needed that were mine and removed any open branches that were related to any debug/development build releases which should clean a lot of things up :D

Comment 6

[Farhan Patel [:farhan]]

I've deleted everyones merged in branches.

Comment 7

[Farhan Patel [:farhan]]

I think we can close this now we!

- CI works on each PR
- CI builds the app for each PR
- Swiftlint does a basic check of code style
- Unit tests run