1293496 - Increase Message Body Limit to 2MB in Sync Production.

Status: VERIFIED FIXED

(Cloud Services :: Operations: Miscellaneous, task)

Description

[Bob Micheletto [:bobm]]

Increase the Sync message body limit to 2MB.  Tested in Bug 1275394.

Comment 1

[Bob Micheletto [:bobm]]

:markh we still want to do this, right?

Comment 2

[Mark Hammond [:markh] [:mhammond]]

(In reply to Bob Micheletto [:bobm] from comment #1)
> :markh we still want to do this, right?

I'm not sure :(  Currently, if we have a record larger than we think will fit, we attempt the upload anyway - hence this change will allow more records to succeed. However, once support for atomic-writes land, the client behaviour is going to change - it will trust the config values and never attempt a record larger than specified.

So in an ideal world, I think we'd:
1) take this as a short-term fix.
2) ensure info/configuration correctly reports a max of 2MB per post - if that continues to report 1MB even though 2MB would theoretically work, we will still never exceed 1MB.

So on balance I think we do - that will help while atomic writes rides the train.

I hope that makes sense.

Comment 3

[Bob Micheletto [:bobm]]

(In reply to Mark Hammond [:markh] from comment #2)
> (In reply to Bob Micheletto [:bobm] from comment #1)

> So in an ideal world, I think we'd:
> 1) take this as a short-term fix.
Sounds good

> 2) ensure info/configuration correctly reports a max of 2MB per post - if
> that continues to report 1MB even though 2MB would theoretically work, we
> will still never exceed 1MB.
I've added a note here: https://bugzilla.mozilla.org/show_bug.cgi?id=1250189#c72

> So on balance I think we do - that will help while atomic writes rides the
> train.
> 
> I hope that makes sense.
I think it does- I'm planing on rolling this out this week.

Comment 4

[Bob Micheletto [:bobm]]

The 413 rate dropped by better than 50% when this was put in place.  Closing this bug.  We can revisit increasing if necessary.

Comment 5

[Karl Thiessen [:kthiessen, he/him]]

Verified.