Closed Bug 1293513 Opened 6 years ago Closed 6 years ago

2.45 - 12.92% tart / tp5o / tp5o responsiveness (linux64, osx-10-10, windows7-32, windows8-64, windowsxp) regression on push f54fea6078ddf0023a4307a25264c6ece653e503 (Sat Aug 6 2016)


(Toolkit :: Password Manager, defect, P1)

51 Branch



Tracking Status
firefox48 --- unaffected
firefox49 --- unaffected
firefox50 --- unaffected
firefox51 --- fixed


(Reporter: ashiue, Assigned: MattN)



(Keywords: perf, regression, talos-regression)


(1 file)

Talos has detected a Firefox performance regression from push f54fea6078ddf0023a4307a25264c6ece653e503. As author of one of the patches included in that push, we need your help to address this regression.

Summary of tests that regressed:

  tp5o summary windows7-32 opt: 363.9 -> 378.27 (3.95% worse)
  tp5o responsiveness windows7-32 opt: 80.28 -> 90.66 (12.92% worse)
  tp5o summary windows8-64 opt: 325.32 -> 338.89 (4.17% worse)
  tp5o responsiveness linux64 opt: 48.5 -> 53.42 (10.15% worse)
  tp5o summary linux64 opt e10s: 341.66 -> 350.04 (2.45% worse)
  tp5o summary osx-10-10 opt: 286.69 -> 295.65 (3.13% worse)
  tp5o summary windows7-32 opt e10s: 349.82 -> 359.84 (2.86% worse)
  tp5o summary windows8-64 opt e10s: 303.17 -> 312.13 (2.95% worse)
  tp5o summary windows7-32 pgo e10s: 254.85 -> 262.79 (3.11% worse)
  tp5o summary windows7-32 pgo: 259.77 -> 270.71 (4.21% worse)
  tp5o summary linux64 opt: 340.23 -> 350.88 (3.13% worse)
  tp5o summary windowsxp opt: 363.6 -> 384.14 (5.65% worse)
  tart summary windows7-32 opt e10s: 6.46 -> 6.66 (2.95% worse)
  tp5o summary windowsxp opt e10s: 348.68 -> 362.33 (3.91% worse)

You can find links to graphs and comparison views for each of the above tests at:

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the Talos jobs in a pushlog format.

To learn more about the regressing test(s), please see:

For information on reproducing and debugging the regression, either on try or locally, see:

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations:
This issue might be caused by push:

Hi Matthew, as you are the patch author, can you take a look at this and determine what is the root cause? Thanks!
Flags: needinfo?(MattN+bmo)
I suspect this is related to the progress listener in bug 1166947 but I'm surprised that it would affect TART as I don't think there are <input type=password>. The progress listener should only be setup on pages with password fields and should be removed otherwise. I'll investigate this more tomorrow.
Matt, thanks for looking into this, did you come up with any findings?
I haven't had too much time to look into this yet but started on Thursday (I was on PTO Friday). I started by trying to see if the pages that reduced responsiveness had password fields on them:
> sed 's/^http:\/\/localhost\/page_load_test\/tp5n\///' tp5o.manifest | sed 's/\/.*$//' | xargs -n 1 grep -E -R -i -l --include "*.htm*" 'type=.?password' {} \; | sed 's/\/.*//'

The following contain /type=.?password/:

I used the page set from which I hope is up-to-date.

If I look at then the following regressed significantly:

The only overlap between the two sets is which is discouraging since bug 1166947 shouldn't affect pages that don't have <input type="password">. Is it possible that is the only one that regressed and the others are noise?
No longer blocks: 1291346
Assignee: nobody → MattN+bmo
Component: Untriaged → Password Manager
Product: Firefox → Toolkit
I noticed that we are setting up the progress listener in onDOMInputPasswordAdded even when the input is in a form though bug 1166947 was only aiming to help with formless inputs. Handling password inputs in a form but without a submit event was split into bug 1287202 so this patch may just delay the problem until bug 1287202 but gets rid of the extra work in the meantime.

Try push:
Flags: needinfo?(MattN+bmo)
Priority: -- → P1
Has Regression Range: --- → yes
that sounds like a good root cause- glad we have a path forward in the short and long term.
Comment on attachment 8781298 [details]
Bug 1293513 - Only setup login manager's progress listener for formless passwords inputs.
Attachment #8781298 - Flags: review?(dolske) → review+
Pushed by
Only setup login manager's progress listener for formless passwords inputs. r=Dolske
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
looking at this, I see that we fixed the majority of the regression, I am happy with that.
You need to log in before you can comment on or make changes to this bug.