1293554 - Only run SETA's loadSkipConfig on the test scheduler

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

AFAICT it only affects scheduling [1][2], so only the test scheduler needs to query the SETA server.

[1] https://hg.mozilla.org/build/buildbot-configs/file/production/mozilla-tests/config_seta.py#l114
[2] https://dxr.mozilla.org/build-central/search?q=skipconfig+path%3Abuildbotcustom&redirect=false

Comment 1

[Kim Moir [:kmoir] ET]

I investigated this a bit this morning.  To me it seems like the best thing to be would be to set DISABLE_SETA=1 in the puppet configs for the test masters, investigating how to do this.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Thanks for looking at this Kim. I'd hoped we could look at 'role' in master_config.json, but didn't manage to navigate the tangle of imports which make it non-obvious how to do that.

If we use the DISABLE_SETA=1 way solution, could we put a comment in mozilla-tests/config.py and mozilla-tests/mobile_config.py (eg where we call loadSkipConfig) explaining it only has an effect on the test scheduler ? Otherwise it would be easy to be debugging and miss the variable, leading to confusion.

Comment 3

[Kim Moir [:kmoir] ET]

Sure, I can do that.  Not sure what the best solution is will have to do some testing.

Comment 4

[Kim Moir [:kmoir] ET]

So it doesn't look like puppet is the best solution for setting this since it would only be set when setting up a new server without modifying the user env for cltbld certain masters. I've looked at setting this in the buildbot-configs/mozilla-tests/config.py by conditionally setting imports for config_seta.py but the tangle of imports, is well quite tangled.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

I don't think it's worth the time rearranging imports and avoiding bustage from new circular imports. Maybe we should just go for a pragmatic solution like
* read master_config.json in mozilla-tests/{config.py,mobile_config.py}, then only import config_seta and call loadSkipConfig if master_config['role'] == 'scheduler'
* aki's quick solution from when we were debugging - do a 'if "scheduler" in os.getcwd()' test

Comment 6

[Kim Moir [:kmoir] ET]

Attachment: bug1293554.patch

Comment 7

[Kim Moir [:kmoir] ET]

Attachment: bug1293554tools.patch

patch to cleanup config_seta.py file from masters once they don't need it

Comment 8

[Kim Moir [:kmoir] ET]

Attachment: bug1293554.patch

Comment 9

[Kim Moir [:kmoir] ET]

Attachment: bug1293554.patch

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8781145 [details] [diff] [review]
bug1293554.patch

Nice catch on the master setup.

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8781143 [details] [diff] [review]
bug1293554tools.patch

You'll need to change %(bbconfigs_dir)s/mozilla-tests/ to %(master_dir)s/, and suspect you meant 'remove' instead of 'remote'. r+ with those fixed.

Comment 12

[Kim Moir [:kmoir] ET]

Attachment: bug1293554tools.patch

Comment 13

[Kim Moir [:kmoir] ET]

tools file actually looked like this

I cleaned config_seta.py symlinks were cleaned from the test masters using the fabric action