1293569 - Crash in PLDHashTable::Add | nsBaseHashtable<T>::Put | mozilla::a11y::AccessibleWrap::GetChildIDFor

Status: RESOLVED WORKSFORME

(Core :: Disability Access APIs, defect)

Description

[Ting-Yu Chou [:ting] (away)]

This bug was filed from the Socorro interface and is 
report bp-4fe297c3-3d82-47b8-90cd-a87f32160808.
=============================================================

#34 of 0807 Nightly on Windows, 3 crashes from 2 installations.

Comment 1

[Ting-Yu Chou [:ting] (away)]

Based on the minidump, it seems the |doc| [1] is null. Maybe we need another similar check like [2] for |!aAccessible->DocProxyWrapper() && aAccessible->IsProxy()|?

[1] https://hg.mozilla.org/mozilla-central/annotate/d42aacfe34af/accessible/windows/msaa/AccessibleWrap.cpp#l1372
[2] https://hg.mozilla.org/mozilla-central/annotate/d42aacfe34af/accessible/windows/msaa/AccessibleWrap.cpp#l1360

Comment 2

[Trevor Saunders (:tbsaunde)]

(In reply to Ting-Yu Chou [:ting] from comment #1)
> Based on the minidump, it seems the |doc| [1] is null. Maybe we need another
> similar check like [2] for |!aAccessible->DocProxyWrapper() &&
> aAccessible->IsProxy()|?

I'm not sure how 1 can happen, but I don't think 2 should be possible, so I'd like to understand that before just adding that check.

Comment 3

[Trevor Saunders (:tbsaunde)]

also note that bug 1268544 and related work will change this around significantly, so I'm not sure how much its worth investigating until that's sorted out.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Crash volume for signature 'PLDHashTable::Add | nsBaseHashtable<T>::Put | mozilla::a11y::AccessibleWrap::GetChildIDFor':
 - nightly (version 51): 66 crashes from 2016-08-01.
 - aurora  (version 50): 27 crashes from 2016-08-01.
 - beta    (version 49): 34 crashes from 2016-08-02.
 - release (version 48): 22 crashes from 2016-07-25.
 - esr     (version 45): 0 crashes from 2016-05-02.

Crash volume on the last weeks (Week N is from 08-22 to 08-28):
            W. N-1  W. N-2  W. N-3
 - nightly      32      25       7
 - aurora        9       7       4
 - beta          6      12       1
 - release       8       5       5
 - esr           0       0       0

Affected platform: Windows

Crash rank on the last 7 days:
           Browser     Content   Plugin
 - nightly #61
 - aurora  #78
 - beta    #862
 - release #2392
 - esr

Comment 5

[Wesley Branton]

I've also started to get this crash today. Nothing has changed in terms of hardware or software, so I'm not entirely sure why it has started so suddenly.

Here are the crash reports:
bp-f30dc8f2-62cd-4568-bf56-35a502161017
bp-08609246-9488-4c92-a01b-4cff12161016
bp-bc6c1fdc-652e-4abc-be9e-8a8b62161016

Comment 6

[alexander :surkov (:asurkov)]

no fresh crashes, the last one was seen in 48 

https://crash-stats.mozilla.com/signature/?signature=PLDHashTable%3A%3AAdd%20%7C%20mozilla%3A%3Aa11y%3A%3AAccessibleWrap%3A%3AGetChildIDFor&date=%3E%3D2017-07-26T20%3A42%3A00.000Z&date=%3C2017-08-02T20%3A42%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1#reports