1293572 - Flushing a decoder that is not initialized will hang

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

Found this bug when testing suspend/resume reader.

https://hg.mozilla.org/mozilla-central/file/e78975b53563d80c99ebfbdf8a9fbf6b829a8a48/dom/media/MediaFormatReader.cpp#l466

When the reader is suspended, it is possible to flush a DecoderData::mDecoder which is created but not initialized and it turns out to hang on my Android device.

We should create no decoders at all when the reader is suspended.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1293572 - Flushing a decoder that is not initialized causes hang. Don't create decoders when the reader is suspened.

Review commit: https://reviewboard.mozilla.org/r/70268/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70268/

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8779220 [details]
Bug 1293572 - Flushing a decoder that is not initialized causes hang. Don't create decoders when the reader is suspened.

https://reviewboard.mozilla.org/r/70268/#review68004

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b8517876729
Flushing a decoder that is not initialized causes hang. Don't create decoders when the reader is suspened. r=jya

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6b8517876729