1293595 - Crash in java.lang.NullPointerException: at org.mozilla.gecko.BrowserApp.onAttachedToWindow(BrowserApp.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

This bug was filed from the Socorro interface and is 
report bp-574fbead-c16b-4a44-8201-7beb72160803.
=============================================================

> java.lang.NullPointerException
> 	at org.mozilla.gecko.BrowserApp.onAttachedToWindow(BrowserApp.java:975)
> 	at android.support.v7.internal.view.WindowCallbackWrapper.onAttachedToWindow(Unknown Source)
> 	at com.android.internal.policy.impl.PhoneWindow$DecorView.onAttachedToWindow(PhoneWindow.java:2469)
> [..]

Comment 1

[Andrzej Hunt :ahunt]

Based on the most recent reports, this seems to be happening at:
mDoorhangerOverlay.setVisibility(View.VISIBLE);

I don't see how this would happen unless the layout hasn't been inflated yet, in this case layout inflation happens in GeckoApp.onCreate(). There don't seem to be any guarantees about onAttachedToWindow happening before or after onCreate, if it happens before onCreate, we don't have a layout, and findViewById will return null. (That does however seem implausible, shouldn't onCreate be one of the first calls?)

Looking back at the history: it looks like we wanted to show this doorhanger on all devices except 2.3, but nowadays we show the doorhanger on all supported devices - so we should just set it to visible in the layout, and not flip the visibility in code:
https://hg.mozilla.org/mozilla-central/diff/5a706e4cc1f0/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#l1.12

Comment 2

[Andrzej Hunt :ahunt]

We still need to set mDoorHangerOverlay for other parts of BrowserApp, but we can findViewById() it during onCreate instead of onAttachedToWindow, which seems more standard / reliable?

Comment 3

[Andrzej Hunt :ahunt]

Attachment: Bug 1293595 - Make doorhanger overlay visible by default, and retrieve it during onCreate

Retrieving the doorhanger during onAttachedToWindow seems to be unreliable, resulting in NPE's when
it doesn't work (the only logical explanation would be that onCreate hasn't been called yet, meaning
we don't have a layout yet). We should instead findViewById() it during onCreate, where the layout
is guaranteed to exist.

Since we show the overlay on all devices now, we can make it visible by default, whereas in the past
we had a condition to only enable it on > 2.3 devices.

Review commit: https://reviewboard.mozilla.org/r/72976/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72976/

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8782982 [details]
Bug 1293595 - Make doorhanger overlay visible by default, and retrieve it during onCreate

https://reviewboard.mozilla.org/r/72976/#review71352

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Can we land this?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcdac0d4b2d5
Make doorhanger overlay visible by default, and retrieve it during onCreate r=sebastian

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fcdac0d4b2d5