1293604 - Replace NS_STYLE_FLOAT_* with StyleFloat enum class

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1293604 - Replace NS_STYLE_FLOAT_* with StyleFloat enum class.

Review commit: https://reviewboard.mozilla.org/r/70304/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70304/

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 8779279 [details]
Bug 1293604 - Replace NS_STYLE_FLOAT_* with StyleFloat enum class.

https://reviewboard.mozilla.org/r/70304/#review67682

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8779279 [details]
Bug 1293604 - Replace NS_STYLE_FLOAT_* with StyleFloat enum class.

https://reviewboard.mozilla.org/r/70304/#review67930

::: layout/style/nsStyleStruct.h:2834
(Diff revision 1)
>                                  //         to mDisplay
>    uint8_t mContain;             // [reset] see nsStyleConsts.h NS_STYLE_CONTAIN_*
>    uint8_t mAppearance;          // [reset]
>    uint8_t mPosition;            // [reset] see nsStyleConsts.h
> -  uint8_t mFloat;               // [reset] see nsStyleConsts.h NS_STYLE_FLOAT_*
> -  uint8_t mOriginalFloat;       // [reset] saved mFloat for position:absolute/fixed;
> +
> + // [reset] See StyleFloat in nsStyleConsts.h.

This indentation is wrong. I'll upload a new patch to fix it.

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8779279 [details]
Bug 1293604 - Replace NS_STYLE_FLOAT_* with StyleFloat enum class.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/70304/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bc47f02e322
Replace NS_STYLE_FLOAT_* with StyleFloat enum class. r=dbaron

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9bc47f02e322