Replace NS_STYLE_FLOAT_* with StyleFloat enum class

RESOLVED FIXED in Firefox 51

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: TYLin, Assigned: TYLin)

Tracking

(Blocks 1 bug)

unspecified
mozilla51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

No description provided.
Blocks: 1277133
Assignee: nobody → tlin
Comment on attachment 8779279 [details]
Bug 1293604 - Replace NS_STYLE_FLOAT_* with StyleFloat enum class.

https://reviewboard.mozilla.org/r/70304/#review67682
Attachment #8779279 - Flags: review?(dbaron) → review+
Comment on attachment 8779279 [details]
Bug 1293604 - Replace NS_STYLE_FLOAT_* with StyleFloat enum class.

https://reviewboard.mozilla.org/r/70304/#review67930

::: layout/style/nsStyleStruct.h:2834
(Diff revision 1)
>                                  //         to mDisplay
>    uint8_t mContain;             // [reset] see nsStyleConsts.h NS_STYLE_CONTAIN_*
>    uint8_t mAppearance;          // [reset]
>    uint8_t mPosition;            // [reset] see nsStyleConsts.h
> -  uint8_t mFloat;               // [reset] see nsStyleConsts.h NS_STYLE_FLOAT_*
> -  uint8_t mOriginalFloat;       // [reset] saved mFloat for position:absolute/fixed;
> +
> + // [reset] See StyleFloat in nsStyleConsts.h.

This indentation is wrong. I'll upload a new patch to fix it.
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9bc47f02e322
Replace NS_STYLE_FLOAT_* with StyleFloat enum class. r=dbaron
https://hg.mozilla.org/mozilla-central/rev/9bc47f02e322
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.