Correct MSE web-platform-test

RESOLVED FIXED in Firefox 51

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

(Blocks 1 bug)

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(11 attachments)

58 bytes, text/x-review-board-request
gerald
: review+
Details
58 bytes, text/x-review-board-request
gerald
: review+
Details
58 bytes, text/x-review-board-request
gerald
: review+
Details
58 bytes, text/x-review-board-request
gerald
: review+
Details
58 bytes, text/x-review-board-request
gerald
: review+
Details
58 bytes, text/x-review-board-request
gerald
: review+
Details
58 bytes, text/x-review-board-request
gerald
: review+
Details
58 bytes, text/x-review-board-request
gerald
: review+
Details
58 bytes, text/x-review-board-request
gerald
: review+
Details
58 bytes, text/x-review-board-request
gerald
: review+
Details
58 bytes, text/x-review-board-request
gerald
: review+
Details
(Assignee)

Description

3 years ago
All the failures remaining are due to bugs in the tests themselves.

This bug aim at fixing those.

Most of them are related to invalid calculations in the buffered range.
Both Blink and Edge are incorrectly using dts to perform operations on the sourcebuffer, when they should be using pts.

We'll fix the tests. So hopefully other parties will fix their implementations quicker.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment on attachment 8779628 [details]
Bug 1293613: don't assume playback won't be finished by the time the seeked event is fired.

https://reviewboard.mozilla.org/r/70590/#review67958

r+ with nit:

Typo in commit description: "timestamps verify" -> "Timestamps verified".
Attachment #8779628 - Flags: review?(gsquelart) → review+
Comment on attachment 8779629 [details]
Bug 1293613: Update manifest with new test scripts.

https://reviewboard.mozilla.org/r/70592/#review67960
Attachment #8779629 - Flags: review?(gsquelart) → review+
Comment on attachment 8779630 [details]
Bug 1293613: Correct mediasource-duration.html

https://reviewboard.mozilla.org/r/70594/#review67962

r+ with nit:

Typo in commit description: "end time 0f" -> "end time of"
Attachment #8779630 - Flags: review?(gsquelart) → review+
Comment on attachment 8779631 [details]
Bug 1293613: An invalid or revoked MediaSource URI can't be trace to a MediaSource object.

https://reviewboard.mozilla.org/r/70596/#review67968

r+ with usual typo in commit description: "trace" -> "traced".
Attachment #8779631 - Flags: review?(gsquelart) → review+
Comment on attachment 8779632 [details]
Bug 1293613: Don't assume all segments audio and video track start at the same time point.

https://reviewboard.mozilla.org/r/70598/#review67976

r+ with the usual commit description typos:
"all segments audio and video track" -> "all segments' audio and video tracks"
"Audio track and video tracks have" -> "Audio and video tracks have"
"a different start and end time" -> "different start and end times"
Attachment #8779632 - Flags: review?(gsquelart) → review+
Comment on attachment 8779633 [details]
Bug 1293613: Don't assume that all videos start at 0.

https://reviewboard.mozilla.org/r/70600/#review67978
Attachment #8779633 - Flags: review?(gsquelart) → review+
Comment on attachment 8779634 [details]
Bug 1293613: Make liveseekable test run.

https://reviewboard.mozilla.org/r/70602/#review67980
Attachment #8779634 - Flags: review?(gsquelart) → review+
Comment on attachment 8779635 [details]
Bug 1293613: Update test using new manifest details.

https://reviewboard.mozilla.org/r/70604/#review67982

::: testing/web-platform/tests/media-source/mediasource-seek-during-pending-seek.html:105
(Diff revision 1)
>                });
>  
>                test.waitForExpectedEvents(function()
>                {
> -                  assert_true(mediaElement.seeking, 'mediaElement is still seeking');
> -
> +                  // Note that we can't assume that the element is still seeking
> +                  // when the seeking event is fired as the operation is asyncronous.

"asyncronous" -> "asynchronous"
Comment on attachment 8779635 [details]
Bug 1293613: Update test using new manifest details.

https://reviewboard.mozilla.org/r/70604/#review67984
Attachment #8779635 - Flags: review?(gsquelart) → review+
Comment on attachment 8779636 [details]
Bug 1293613: Don't assume that once playing event has fired, the earlier appendBuffer has completed.

https://reviewboard.mozilla.org/r/70606/#review67986
Attachment #8779636 - Flags: review?(gsquelart) → review+
Comment on attachment 8779637 [details]
Bug 1293613: amend expected MSE web-platform-tests expected results.

https://reviewboard.mozilla.org/r/70608/#review67988
Attachment #8779637 - Flags: review?(gsquelart) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment on attachment 8779968 [details]
Bug 1293613: Never attempt to read past end of manifest table.

https://reviewboard.mozilla.org/r/70836/#review68224
Attachment #8779968 - Flags: review?(gsquelart) → review+

Comment 44

3 years ago
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96e477498ea4
Don't assume that all videos start at 0. r=gerald
https://hg.mozilla.org/integration/autoland/rev/2cae41cf5ea5
Update manifest with new test scripts. r=gerald
https://hg.mozilla.org/integration/autoland/rev/0db1ed3d603b
Correct mediasource-duration.html r=gerald
https://hg.mozilla.org/integration/autoland/rev/1ea1ecf7d4b0
An invalid or revoked MediaSource URI can't be trace to a MediaSource object. r=gerald
https://hg.mozilla.org/integration/autoland/rev/bf05ed42e18a
Don't assume all segments audio and video track start at the same time point. r=gerald
https://hg.mozilla.org/integration/autoland/rev/c4a4c5ead421
Don't assume that all videos start at 0. r=gerald
https://hg.mozilla.org/integration/autoland/rev/d5e63c7b5409
Make liveseekable test run. r=gerald
https://hg.mozilla.org/integration/autoland/rev/07b2fa5b4c94
Update test using new manifest details. r=gerald
https://hg.mozilla.org/integration/autoland/rev/bde91881654f
Don't assume that once playing event has fired, the earlier appendBuffer has completed. r=gerald
https://hg.mozilla.org/integration/autoland/rev/9f514918f335
Never attempt to read past end of manifest table. r=gerald
https://hg.mozilla.org/integration/autoland/rev/7462a01bd906
amend expected MSE web-platform-tests expected results. r=gerald
Comment hidden (mozreview-request)
(Assignee)

Updated

3 years ago
Attachment #8779629 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Attachment #8779630 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Attachment #8779631 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Attachment #8779632 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Attachment #8779633 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Attachment #8779634 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Attachment #8779635 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Attachment #8779636 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Attachment #8779968 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Attachment #8779637 - Attachment is obsolete: true

Comment 46

3 years ago
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/31e906fb345e
don't assume playback won't be finished by the time the seeked event is fired. r=gerald
(Assignee)

Updated

3 years ago
Attachment #8779629 - Attachment is obsolete: false
(Assignee)

Updated

3 years ago
Attachment #8779630 - Attachment is obsolete: false
(Assignee)

Updated

3 years ago
Attachment #8779631 - Attachment is obsolete: false
(Assignee)

Updated

3 years ago
Attachment #8779632 - Attachment is obsolete: false
(Assignee)

Updated

3 years ago
Attachment #8779633 - Attachment is obsolete: false
(Assignee)

Updated

3 years ago
Attachment #8779634 - Attachment is obsolete: false
(Assignee)

Updated

3 years ago
Attachment #8779635 - Attachment is obsolete: false
(Assignee)

Updated

3 years ago
Attachment #8779636 - Attachment is obsolete: false
(Assignee)

Updated

3 years ago
Attachment #8779637 - Attachment is obsolete: false
(Assignee)

Updated

3 years ago
Attachment #8779968 - Attachment is obsolete: false
You need to log in before you can comment on or make changes to this bug.