1293666 - Add initializer_list ctor to AutoTArray

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

I assume this is just an oversight of bug 1228641, but I don't see any reason to not have it. (I thought I might have a use for it, but I think not after all.)

Comment 1

[Andrew McCreight [:mccr8]]

I only found a few places that could use this, so that isn't the strongest argument for it, but oh well.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1293666 - Add initializer_list ctor to AutoTArray.

Review commit: https://reviewboard.mozilla.org/r/70338/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70338/

Comment 3

[Andrew McCreight [:mccr8]]

Hmm, I guess that's actually bogus. I expect you have to call Init() or something like the other ctors.

Comment 4

[Andrew McCreight [:mccr8]]

Comment on attachment 8779350 [details]
Bug 1293666 - Add initializer_list ctor to AutoTArray.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/70338/diff/1-2/

Comment 5

[Andrew McCreight [:mccr8]]

This passes an ASan try run which hopefully would have caught the prior error?
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=bdef787152b8

Comment 6

[Nathan Froyd [:froydnj]]

Comment on attachment 8779350 [details]
Bug 1293666 - Add initializer_list ctor to AutoTArray.

https://reviewboard.mozilla.org/r/70338/#review68018

Sure, why not?

::: docshell/base/nsDocShell.cpp:4455
(Diff revision 2)
>      return NS_OK;
>    }
>  
>    int32_t index = 0;
>    sessionHistory->GetIndex(&index);
> -  AutoTArray<uint64_t, 16> ids;
> +  AutoTArray<uint64_t, 16> ids({mHistoryID});

lol @ a 16 element auto array being used here.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c42c82251d6
Add initializer_list ctor to AutoTArray. r=froydnj

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2c42c82251d6