1293737 - Merge ubuntu1204-test and desktop-test

Status: RESOLVED FIXED

(Taskcluster Graveyard :: Docker Images, defect)

Description

[Gregory Szorc [:gps]]

+++ This bug was initially created as a clone of Bug #1293686 +++

Let's give the same treatment to the Ubuntu 12.04 images that we did for 16.04 in bug 1293686.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1293737 - Move ubuntu1204-test's system-setup.sh to recipes;

In preparation for deleting this image.

Review commit: https://reviewboard.mozilla.org/r/70442/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70442/

Comment 2

[Gregory Szorc [:gps]]

Attachment: Bug 1293737 - Merge ubuntu1204-test and ubuntu1204-test-upd into desktop-test;

We're giving the same treatment to the Ubuntu 12.04 test image that we
did to the Ubuntu 16.04 image in bug 1293686.

As of this commit, the image can be fully regenerated from changes in
tree: no Docker Hub pushes necessary.

A downside is would could get bit by lack of determinism in image
building. But that's already a problem.

Since the ubuntu1204-test and ubuntu1204-test-upd images are no longer
used, they have been deleted.

Review commit: https://reviewboard.mozilla.org/r/70444/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70444/

Comment 3

[Gregory Szorc [:gps]]

Attachment: Bug 1293737 - Add some common settings to global hgrc;

The install-mercurial.sh script takes care of installing a global hgrc.
If we want Mercurial settings, that's where they should be defined.

A number of Docker images had redundantly maintained versions of
/home/worker/.hgrc. We've deleted some instances of these hgrc files
because I thought they were cargo culted. It turns out that the config
was added to support one-click loaners (see bug 1250904).

Since there is little harm in enabling extensions globally, we just do
that in the shared install-mercurial.sh script and do away with the
custom hgrc.

It's worth noting that the CA path defined in the custom hgrc is not
needed because the Mercurial package installed by install-mercurial.sh
configures this correctly.

Review commit: https://reviewboard.mozilla.org/r/70446/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70446/

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8779460 [details]
Bug 1293737 - Move ubuntu1204-test's system-setup.sh to recipes;

https://reviewboard.mozilla.org/r/70442/#review68048

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8779461 [details]
Bug 1293737 - Merge ubuntu1204-test and ubuntu1204-test-upd into desktop-test;

https://reviewboard.mozilla.org/r/70444/#review68050

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8779462 [details]
Bug 1293737 - Add some common settings to global hgrc;

https://reviewboard.mozilla.org/r/70446/#review68052

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f49eaafadcb
Move ubuntu1204-test's system-setup.sh to recipes; r=dustin
https://hg.mozilla.org/integration/autoland/rev/6c38f7c596fc
Merge ubuntu1204-test and ubuntu1204-test-upd into desktop-test; r=dustin
https://hg.mozilla.org/integration/autoland/rev/3995b9f62fe3
Add some common settings to global hgrc; r=dustin

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6f49eaafadcb
https://hg.mozilla.org/mozilla-central/rev/6c38f7c596fc
https://hg.mozilla.org/mozilla-central/rev/3995b9f62fe3