fix "dynamic" requires in autocomplete.js

RESOLVED FIXED in Firefox 51

Status

enhancement
P1
normal
RESOLVED FIXED
3 years ago
11 months ago

People

(Reporter: tromey, Assigned: tromey)

Tracking

unspecified
Firefox 51
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: [reserve-html])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
There's a bit of code in autocomplete.js that webpack thinks is dynamically
calling require.  Easy to fix and makes webpack happy.
Comment hidden (mozreview-request)

Comment 2

3 years ago
mozreview-review
Comment on attachment 8779477 [details]
Bug 1293756 - avoid dynamic requires in autocomplete.js;

https://reviewboard.mozilla.org/r/70456/#review67774
Attachment #8779477 - Flags: review?(bgrinstead) → review+
Iteration: --- → 51.1 - Aug 15
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html] → [reserve-html]

Comment 3

3 years ago
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3030bd212811
avoid dynamic requires in autocomplete.js; r=bgrins

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3030bd212811
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51

Updated

11 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.