1293773 - If you change r+ status in mozreview after typing a summary, the summary gets converted to include HTML junk

Status: RESOLVED DUPLICATE of bug 1283024

(MozReview Graveyard :: General, defect)

Description

[Daniel Holbert [:dholbert]]

Sometimes when I'm completing a review in mozreview, and I've typed up a review summary and then I adjust the review flag from being unset to being r+ (or from r+ to r-, etc), then the review summary reappears as a text box with HTML junk inserted into it.

See for example bug 1288992 comment 7 (which has "<p>" tags that I did not myself insert -- mozreview inserted them, via this bug).

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1293773: This is just a temporary commit to try to exercise bug 1293773. DO NOT LAND.

Review commit: https://reviewboard.mozilla.org/r/70486/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70486/

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screencast of bug

Comment 3

[Daniel Holbert [:dholbert]]

STR:
 1. Visit https://reviewboard.mozilla.org/r/70486/diff/1 (or any mozreview page probably)
 2. Click "Finish Review"
 3. Type in some text in the "Edit header" box, and click "OK".
 4. Adjust the "Review State" dropdown.

ACTUAL RESULTS:
The "Edit header" box turns into a textbox again, and now it's got a bunch of HTML junk which you have to remove or else it will end up being posted as part of your (plaintext) review comments.

Comment 4

[Daniel Holbert [:dholbert]]

(This has bit me several times now. Hopefully mcote can triage / find someone to work on this.)

Comment 5

[Mark Côté [:mcote]]

Yeah this has been reported several times.  We'll get someone on it shortly.