Closed Bug 1293793 Opened 3 years ago Closed 3 years ago

[webvr] VRFrameData.timestamp's timebase is not a monotonically increasing value

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: kip, Assigned: kip)

References

()

Details

(Whiteboard: [gfx-noted][webvr])

Attachments

(1 file)

The WebVR spec requires VRPose.timebase to be a monotonically increasing value.  The current implementation derives the timebase from PR_Now(), which does not return a monotonically increasing value.
Summary: [webvr] VRPose.timebase is not monotonic → [webvr] VRPose.timebase is not a monotonically increasing value
Whiteboard: [gfx-noted]
With the WebVR 1.1 spec changes, the attribute has been replaced with VRFrameData.timestamp.

The same issue remains; however.
Summary: [webvr] VRPose.timebase is not a monotonically increasing value → [webvr] VRFrameData.timestamp's timebase is not a monotonically increasing value
Blocks: webvr_1.1
No longer depends on: 1250244
Whiteboard: [gfx-noted] → [gfx-noted][webvr]
Assignee: nobody → kgilbert
Attachment #8843131 - Flags: review?(dmu)
Comment on attachment 8843131 [details]
Bug 1293793 - Ensure VRFrameData.timestamp is a monotonically increasing value

https://reviewboard.mozilla.org/r/116898/#review118922

LGTM
Attachment #8843131 - Flags: review?(dmu) → review+
Pushed by kgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9f89c64ea95a
Ensure VRFrameData.timestamp is a monotonically increasing value r=daoshengmu
https://hg.mozilla.org/mozilla-central/rev/9f89c64ea95a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.