Closed Bug 1293845 Opened 3 years ago Closed 3 years ago

Fix in-tree webidl to be forward-compatible with eventual webgl2 webidl

Categories

(Core :: Canvas: WebGL, defect)

50 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

Attachments

(4 files)

We don't need to implement the whole new webidl list, but we need to at least be forward-compatible.
Here forward-compatible means we reject at least as many things as we're supposed to, and don't allow anything we shouldn't.
Comment on attachment 8779890 [details]
Bug 1293845 - Update webidl to be forward-compatible with final webgl2 webidl. -

https://reviewboard.mozilla.org/r/70794/#review68430
Attachment #8779890 - Flags: review?(mrbkap) → review+
Attachment #8779891 - Flags: review?(mtseng) → review?(hshih)
Attachment #8779892 - Flags: review?(mtseng) → review?(hshih)
Attachment #8779891 - Flags: review?(hshih) → review?(mtseng)
Attachment #8779892 - Flags: review?(hshih) → review?(mtseng)
Comment on attachment 8779891 [details]
Bug 1293845 - Repair texture bindings->internals glue. -

https://reviewboard.mozilla.org/r/70796/#review68672
Attachment #8779891 - Flags: review?(mtseng) → review+
Comment on attachment 8779892 [details]
Bug 1293845 - Handle zero-size TexSubImage. -

https://reviewboard.mozilla.org/r/70798/#review68674
Attachment #8779892 - Flags: review?(mtseng) → review+
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6cd485867a7d
Update webidl to be forward-compatible with final webgl2 webidl. - r=mrbkap
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca7b62d9efb7
Repair texture bindings->internals glue. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2cad6d22d75
Handle zero-size TexSubImage. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b9a31603e34
Update tests to handle new webidl.
Backed out for test failure in test_sab_with_webgl.html on OSX:

https://hg.mozilla.org/integration/mozilla-inbound/rev/45f24b04f52b9861f9dad9c01b17a3bad4851ef7
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b3575129b8ce370b281dc359c51cf102ef85dc5
https://hg.mozilla.org/integration/mozilla-inbound/rev/175885b136b44752dacb503398f0e996d3f07fd7
https://hg.mozilla.org/integration/mozilla-inbound/rev/0afcc7ac94404a00a23f53dd83e5d03aaf12dc5f

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=2b9a31603e348c8edac61f74627674f5a9284976
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=33812600&repo=mozilla-inbound

The next push contains both opt and debug and e10s and non-e10s: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=810a43be36dea816105520b23758e7988f972def

21:34:35     INFO -  2925 INFO TEST-START | dom/canvas/test/webgl-mochitest/test_sab_with_webgl.html
21:34:35     INFO -  ++DOMWINDOW == 46 (0x1327d6000) [pid = 1800] [serial = 46] [outer = 0x128d69800]
21:34:36     INFO -  JavaScript warning: http://mochi.test:8888/tests/dom/canvas/test/webgl-mochitest/test_sab_with_webgl.html, line 58: Error: WebGL: Exceeded 16 live WebGL contexts for this principal, losing the least recently used one.
21:34:36     INFO -  WebGL(0x127237800)::ForceLoseContext
21:34:36     INFO -  JavaScript warning: http://mochi.test:8888/tests/dom/canvas/test/webgl-mochitest/test_sab_with_webgl.html, line 141: Error: WebGL: Exceeded 16 live WebGL contexts for this principal, losing the least recently used one.
21:34:36     INFO -  WebGL(0x11dd2c000)::ForceLoseContext
21:34:36     INFO -  TEST-INFO | started process screencapture
21:34:36     INFO -  TEST-INFO | screencapture: exit 0
21:34:36     INFO -  2926 INFO TEST-PASS | dom/canvas/test/webgl-mochitest/test_sab_with_webgl.html | Program should link.
21:34:36     INFO -  2927 INFO TEST-PASS | dom/canvas/test/webgl-mochitest/test_sab_with_webgl.html | bufferData with SAB as input parameter works ok.
21:34:36     INFO -  2928 INFO TEST-PASS | dom/canvas/test/webgl-mochitest/test_sab_with_webgl.html | bufferSubData with SAB as input parameter works ok.
21:34:36     INFO -  2929 INFO TEST-PASS | dom/canvas/test/webgl-mochitest/test_sab_with_webgl.html | Should be no errors.
21:34:36     INFO -  2930 INFO TEST-PASS | dom/canvas/test/webgl-mochitest/test_sab_with_webgl.html | Should be [0.2000, 0.4000, 0.6000, 1.000], was [0.2000, 0.4000, 0.6000, 1.000],
21:34:36     INFO -  2931 INFO TEST-PASS | dom/canvas/test/webgl-mochitest/test_sab_with_webgl.html | texImage2D() with SAB as input parameter works ok.
21:34:36     INFO -  2932 INFO TEST-PASS | dom/canvas/test/webgl-mochitest/test_sab_with_webgl.html | texSubImage2D() with SAB as input parameter works ok.
21:34:36     INFO -  2933 INFO TEST-PASS | dom/canvas/test/webgl-mochitest/test_sab_with_webgl.html | Should be no errors after test.
21:34:36     INFO -  2934 INFO TEST-UNEXPECTED-FAIL | dom/canvas/test/webgl-mochitest/test_sab_with_webgl.html | uncaught exception - TypeError: Argument 3 of WebGL2RenderingContext.getBufferSubData does not implement interface ArrayBufferView. at @http://mochi.test:8888/tests/dom/canvas/test/webgl-mochitest/test_sab_with_webgl.html:159:3
21:34:36     INFO -  @http://mochi.test:8888/tests/dom/canvas/test/webgl-mochitest/test_sab_with_webgl.html:135:2
21:34:36     INFO -      simpletestOnerror@SimpleTest/SimpleTest.js:1609:11
21:34:36     INFO -      OnErrorEventHandlerNonNull*@SimpleTest/SimpleTest.js:1589:1
21:34:36     INFO -  JavaScript error: http://mochi.test:8888/tests/dom/canvas/test/webgl-mochitest/test_sab_with_webgl.html, line 159: TypeError: Argument 3 of WebGL2RenderingContext.getBufferSubData does not implement interface ArrayBufferView.
Flags: needinfo?(jgilbert)
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad2378096461
Update webidl to be forward-compatible with final webgl2 webidl. - r=mrbkap
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ad41a92a841
Repair texture bindings->internals glue. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/ccdaa7a3d515
Handle zero-size TexSubImage. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/14c3972b8e91
Update tests to handle new webidl.
Jeff, we need this to enable ANGLE with WebGL2. Please uplift this to FF 50.
Comment on attachment 8779890 [details]
Bug 1293845 - Update webidl to be forward-compatible with final webgl2 webidl. -

Approval Request Comment
With WebGL2 in FF50, we need this ANGLE update to fix and enable functionality.
Attachment #8779890 - Flags: approval-mozilla-aurora?
Comment on attachment 8779891 [details]
Bug 1293845 - Repair texture bindings->internals glue. -

Approval Request Comment
With WebGL2 in FF50, we need this ANGLE update to fix and enable functionality.
Attachment #8779891 - Flags: approval-mozilla-aurora?
Comment on attachment 8779892 [details]
Bug 1293845 - Handle zero-size TexSubImage. -

Approval Request Comment
With WebGL2 in FF50, we need this ANGLE update to fix and enable functionality.
Attachment #8779892 - Flags: approval-mozilla-aurora?
Comment on attachment 8779890 [details]
Bug 1293845 - Update webidl to be forward-compatible with final webgl2 webidl. -

50 moved to Beta today.
Attachment #8779890 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Attachment #8779891 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Attachment #8779892 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Comment on attachment 8779890 [details]
Bug 1293845 - Update webidl to be forward-compatible with final webgl2 webidl. -

Need for WebGL2 support. Beta50+
Attachment #8779890 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #8779891 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #8779892 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Blocks: 1313541
Flags: needinfo?(jgilbert)
You need to log in before you can comment on or make changes to this bug.