1293938 - Search bar popup displays clock icons incorrectly if the search history has more than 7 candidates

Status: NEW

(Firefox :: Search, defect, P5)

Description

[Masatoshi Kimura [:emk]]

Steps to reproduce:
1. Seach 10 times for 10 different words starting with the same string using the search bar. (FOr example, search for "test0", search for "test1", ... search for "test9")
2. Type the common prefix ("test" for this example) into the search bar.

Actual result:
The first seven entries in the popup will come from the search history. The remaining three entries will come from suggestions. But all 10 entries will have a clock icon that indicates that the entry comes from the history.

Expected result:
The last three entries should not have the clock icon.

Comment 1

[Drew Willcoxon :adw]

Yeah, strange.

Comment 2

[Marco Bonardo [:mak]]

Paolo, I wonder if this is related to the bug you were seeing where all entries had the clock?

Comment 3

[:Paolo Amadini]

Uh, that's definitely it! I did what comment 0 says while testing, and with less history entries the icons are correct.

Comment 4

[mihir17166]

I would be happy to try and fix the bug. Could someone please assign it to me?

Comment 5

[Drew Willcoxon :adw]

Thanks, let us know when you have questions.

Comment 6

[Mark Banner (:standard8)]

Mihir isn't working on this at the moment.

Comment 7

[Sonia Singla :soniasingla]

I would like to work on this issue.

Regards
Sonia

Comment 8

[Mark Banner (:standard8)]

I've not heard from Sonia recently about this, so I assume she's not continuing at the moment.

Comment 9

[Mark Banner (:standard8)]

I looked at this a while ago, and it turned out more complex than I was expecting. The main issue was that I think the code at issue was in the autocomplete code - but the interactions with the search suggestion code were difficult to resolve for fixing the issue. Realistically, this isn't a very high priority bug, so unassigning myself.