1294003 - Intermittent /media-source/mediasource-removesourcebuffer.html | application crashed [@ mozilla::DXVA2Manager::~DXVA2Manager()] after Assertion failure: NS_IsMainThread()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=11080126&repo=fx-team

https://archive.mozilla.org/pub/firefox/tinderbox-builds/fx-team-win64-debug/1470807675/fx-team_win8_64-debug_test-web-platform-tests-6-bm126-tests1-windows-build7.txt.gz

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1294003 - Ensure we destroy DXVA2Manager on main thread if DXVA init fails.

If initializing DXVA fails, we end up destroying the DXVA2Manager on the
decode task queue. The DXVA2Manager asserts that it's destroyed on the
main thread, so we should dispatch a task to destroy it on the appropriate
thread instead of destorying it on the wrong one.

Review commit: https://reviewboard.mozilla.org/r/77808/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77808/

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8789668 [details]
Bug 1294003 - Ensure we destroy DXVA2Manager on main thread if DXVA init fails.

https://reviewboard.mozilla.org/r/77808/#review76118

::: dom/media/platforms/wmf/WMFVideoMFTManager.cpp:450
(Diff revision 1)
>        hr = decoder->SendMFTMessage(MFT_MESSAGE_SET_D3D_MANAGER, manager);
>        if (SUCCEEDED(hr)) {
>          mUseHwAccel = true;
>        } else {
> -        mDXVA2Manager = nullptr;
> +        nsCOMPtr<nsIRunnable> r(new DestroyDXVA2ManagerOnMainThread(Move(mDXVA2Manager)));
> +        NS_DispatchToMainThread(r);

Just use DeleteOnMainThread() like we do in destructor.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8789668 [details]
Bug 1294003 - Ensure we destroy DXVA2Manager on main thread if DXVA init fails.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77808/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12d5778a37a6
Ensure we destroy DXVA2Manager on main thread if DXVA init fails. r=mattwoodrow

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/12d5778a37a6