1294011 - Obviate manual calls to SECITEM_FreeItem() in PSM

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[:Cykesiopka]

Less manual memory management is good.

Comment 1

[:Cykesiopka]

Attachment: Bug 1294011 - Obviate manual calls to SECITEM_FreeItem() in PSM.

Review commit: https://reviewboard.mozilla.org/r/71212/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/71212/

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8780501 [details]
Bug 1294011 - Obviate manual calls to SECITEM_FreeItem() in PSM.

https://reviewboard.mozilla.org/r/71212/#review68884

Great! r=me

::: security/manager/ssl/nsKeygenHandler.cpp:467
(Diff revision 1)
>      PK11SlotInfo *slot = nullptr;
>      PK11RSAGenParams rsaParams;
> +    mozilla::UniqueSECItem ecParams;
>      SECOidTag algTag;
>      int keysize = 0;
>      void *params = nullptr;

It might be a good idea to add a comment that this pointer is non-owning.

Comment 3

[:Cykesiopka]

Comment on attachment 8780501 [details]
Bug 1294011 - Obviate manual calls to SECITEM_FreeItem() in PSM.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/71212/diff/1-2/

Comment 4

[:Cykesiopka]

Thanks!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f4e4d2d641f

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1bcaa3640e5
Obviate manual calls to SECITEM_FreeItem() in PSM. r=keeler

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a1bcaa3640e5