Obviate manual calls to SECITEM_FreeItem() in PSM

RESOLVED FIXED in Firefox 51

Status

()

Core
Security: PSM
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Tracking

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: [psm-assigned])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Less manual memory management is good.
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8780501 [details]
Bug 1294011 - Obviate manual calls to SECITEM_FreeItem() in PSM.

https://reviewboard.mozilla.org/r/71212/#review68884

Great! r=me

::: security/manager/ssl/nsKeygenHandler.cpp:467
(Diff revision 1)
>      PK11SlotInfo *slot = nullptr;
>      PK11RSAGenParams rsaParams;
> +    mozilla::UniqueSECItem ecParams;
>      SECOidTag algTag;
>      int keysize = 0;
>      void *params = nullptr;

It might be a good idea to add a comment that this pointer is non-owning.
Attachment #8780501 - Flags: review?(dkeeler) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 4

2 years ago
Thanks!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f4e4d2d641f
Keywords: checkin-needed

Comment 5

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a1bcaa3640e5
Obviate manual calls to SECITEM_FreeItem() in PSM. r=keeler
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a1bcaa3640e5
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.