Closed Bug 1294011 Opened 8 years ago Closed 8 years ago

Obviate manual calls to SECITEM_FreeItem() in PSM

Categories

(Core :: Security: PSM, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Details

(Whiteboard: [psm-assigned])

Attachments

(1 file)

Less manual memory management is good.
Comment on attachment 8780501 [details] Bug 1294011 - Obviate manual calls to SECITEM_FreeItem() in PSM. https://reviewboard.mozilla.org/r/71212/#review68884 Great! r=me ::: security/manager/ssl/nsKeygenHandler.cpp:467 (Diff revision 1) > PK11SlotInfo *slot = nullptr; > PK11RSAGenParams rsaParams; > + mozilla::UniqueSECItem ecParams; > SECOidTag algTag; > int keysize = 0; > void *params = nullptr; It might be a good idea to add a comment that this pointer is non-owning.
Attachment #8780501 - Flags: review?(dkeeler) → review+
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a1bcaa3640e5 Obviate manual calls to SECITEM_FreeItem() in PSM. r=keeler
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: