Identical code for different branches in nsCSSRenderingBorders.cpp

RESOLVED FIXED in Firefox 51

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: sylvestre, Assigned: sylvestre)

Tracking

(Blocks: 1 bug, {coverity})

50 Branch
mozilla51
coverity
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: [CID 1362698])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
We have the same code in the branches:
https://dxr.mozilla.org/mozilla-central/source/layout/base/nsCSSRenderingBorders.cpp?q=nsCSSRenderingBorders.cpp&redirect_type=direct#770
that's... embarrassing :P
thank you for taking this!
Comment hidden (mozreview-request)

Comment 3

a year ago
mozreview-review
Comment on attachment 8779731 [details]
Bug 1294015 - Identical code for different branches in nsCSSRenderingBorders.cpp

https://reviewboard.mozilla.org/r/70662/#review68010

Thank you!
Attachment #8779731 - Flags: review?(arai.unmht) → review+

Comment 4

a year ago
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c2463be00065
Identical code for different branches in nsCSSRenderingBorders.cpp r=arai

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c2463be00065
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.