1294088 - JSON Schema ambiguous types on certain keys

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Peter Bengtsson [:peterbe]]

We currently have some keys with ambiguous types. Namely that they can be either a string or an integer. This creates challenges for any database that isn't as friendly and accepting as ElasticSearch.

We should change these to be EITHER string OR integer. And, where we decide that it's integer we'll set/save NULL if `int(value)` fails. 

* build
https://github.com/mozilla/socorro/blob/c34bdeb390a7483e26c62618182d0d99d891bd01/schemas/processed_crash.json#L82
* tiny_block_size
https://github.com/mozilla/socorro/blob/c34bdeb390a7483e26c62618182d0d99d891bd01/schemas/processed_crash.json#L247
* write_combine_size
https://github.com/mozilla/socorro/blob/c34bdeb390a7483e26c62618182d0d99d891bd01/schemas/processed_crash.json#L275

(in the 3 keys found, two of them are called something_something_size so they most likely need to integers or null)

Comment 1

[Peter Bengtsson [:peterbe]]

Note, we renamed "build" to "build_id"
https://github.com/mozilla/socorro/commit/75a5b7b26f9c62f9c402aed99c8cc96dfe1365b6

Comment 2

[Peter Bengtsson [:peterbe]]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/3460

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/8f64da46520f83dea660557a73ba7b52e772c86e
fixes bug 1294088 - JSON Schema ambiguous types on certain keys (#3460)