1294114 - Autophone - ADBTimeout in worker's start_usbwatchdog is uncaught

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

Process nexus-6-2:
Traceback (most recent call last):
  File "/usr/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap
    self.run()
  File "/usr/lib/python2.7/multiprocessing/process.py", line 114, in run
    self._target(*self._args, **self._kwargs)
  File "/mozilla/autophone/autophone/worker.py", line 1100, in run
    self.start_usbwatchdog()
  File "/mozilla/autophone/autophone/worker.py", line 367, in start_usbwatchdog
    if not self.dm.is_app_installed(self.options.usbwatchdog_appname):
  File "/mozilla/autophone/autophone/adb_android.py", line 295, in is_app_installed
    data = self.shell_output("pm list package %s" % app_name, timeout=timeout)
  File "/mozilla/autophone/autophone/adb.py", line 1121, in shell_output
    raise ADBTimeoutError("%s" % adb_process)
ADBTimeoutError: args: adb -s ZX1G22CDPR wait-for-device shell pm list package com.mozilla.autophone.usbwatchdog; echo rc=$?, exitcode: None, stdout: package:com.mozilla.autophone.usbwatchdog, stderr: 

We need to catch and handle these adb timeout errors.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: bug-1294114-v1.patch

A much more manageable patch for your reviewing pleasure.

Comment 2

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/2f64fe0c318e05dcef1e29ba3c2148848ef25af5
deployed 2016-08-12 ~01:25 PDT