1294136 - Don't use !important for -moz-appearance on toolbarseparator and menuseparator

Status: RESOLVED FIXED

(Toolkit :: Themes, defect, P3)

Description

[:Paolo Amadini]

The "!important" on the "-moz-appearance" property for the "toolbarseparator" rule in "toolbar.css" for Linux might not be actually required.

Removing this would also allow the "!important" to be removed from rules overriding the platform one.

Comment 1

[Dão Gottwald [:dao]]

This was added in bug 406075 for no particular reason.

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

Comment 3

[:Paolo Amadini]

Comment on attachment 8779983 [details] [diff] [review]
patch

Review of attachment 8779983 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/linux/customizableui/panelUI.css
@@ +102,1 @@
>  }

Probably this whole block can just be removed, since we have "-moz-appearance: none;" in the shared CSS already.

Comment 4

[:Paolo Amadini]

Comment on attachment 8779983 [details] [diff] [review]
patch

> .PanelUI-subView toolbarseparator,
> .PanelUI-subView menuseparator,
> .cui-widget-panelview menuseparator,
> #PanelUI-footer-inner > toolbarseparator,
> #PanelUI-footer-fxa > toolbarseparator {
>-  -moz-appearance: none !important;
>+  -moz-appearance: none;
> }

...this being the block in question. I've no idea how Splinter chooses how many lines of context to show :-)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/74a3b1f0a148
Don't use !important for -moz-appearance on toolbarseparator and menuseparator. r=paolo

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/74a3b1f0a148