Closed Bug 1294235 Opened 5 years ago Closed 3 years ago

Build signed xpis from source in AOM browser tests

Categories

(Toolkit :: Add-ons Manager, defect, P3)

51 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox51 --- affected
firefox65 --- fixed

People

(Reporter: aswan, Assigned: aswan, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [refactoring] triaged)

Attachments

(1 file, 2 obsolete files)

There are a bunch of addons in toolkit/mozapps/extensions/test/browser/addons use by mochitests in the parent directory.  Since these are mochitests, we have signed xpis in the tree alongside the original code contained within the addons.  No matter what we do, developers who create or modify these tests need to get their add-ons signed, but the current process is confusing.  Kris had the good suggestion of leaving the source code there but instead of checking in the signed xpis, checking in the META-INF directories and then creating loadable xpis at build time.  In this way, there would be no danger of having the source code and xpi be out of sync.
Mentor: amckay
Keywords: good-first-bug
Priority: -- → P3
Whiteboard: [refactoring] triaged
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INACTIVE
Status: RESOLVED → REOPENED
Resolution: INACTIVE → ---
Assignee: nobody → aswan
Status: REOPENED → ASSIGNED
Attachment #9020944 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/08ce1617c481
Status: ASSIGNED → RESOLVED
Closed: 4 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Attachment #9019497 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.