1294235 - Build signed xpis from source in AOM browser tests

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Andrew Swan [:aswan]]

There are a bunch of addons in toolkit/mozapps/extensions/test/browser/addons use by mochitests in the parent directory.  Since these are mochitests, we have signed xpis in the tree alongside the original code contained within the addons.  No matter what we do, developers who create or modify these tests need to get their add-ons signed, but the current process is confusing.  Kris had the good suggestion of leaving the source code there but instead of checking in the signed xpis, checking in the META-INF directories and then creating loadable xpis at build time.  In this way, there would be no danger of having the source code and xpi be out of sync.

Comment 1

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.

Comment 2

[Andrew Swan [:aswan]]

Attachment: Pack xpis for addon manager tests at build time

Comment 3

[Andrew Swan [:aswan]]

Attachment: Bug 1294235 Pack xpis for addon manager tests at build time

Comment 4

[Andrew Swan [:aswan]]

Attachment: Bug 1294235 Pack xpis for addon manager tests at build time r=kmag

Comment 5

[Andrew Swan [:aswan]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/20bdfda7c5739101723ae1495e66816b28ada208
Bug 1294235 Pack xpis for addon manager tests at build time r=kmag

Comment 6

[Andrei Ciure[:aciure]]

Backed out changeset 20bdfda7c573 (bug 1294235) for browser_webext_options.js perma failure

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&group_state=expanded&revision=20bdfda7c5739101723ae1495e66816b28ada208

failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=f2aee8014db6194ee85ec6043263389698a4b1d4&group_state=expanded&selectedJob=208783602&searchStr=windows%2C7%2Copt%2Cmochitests%2Cwith%2Ce10s%2Ctest-windows7-32%2Fopt-mochitest-browser-chrome-e10s-6%2Cm-e10s%28bc6%29

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=f2aee8014db6194ee85ec6043263389698a4b1d4&group_state=expanded&selectedJob=208783124&searchStr=windows%2C7%2Cdebug%2Ctest-windows7-32%2Fdebug-test-verify-e10s-1%2C%28tv1%29

backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/8ae21741b57cda1f74dd4cec977cb5d0b240277e

Comment 7

[Andrew Swan [:aswan]]

Try run with fixed pgo tests:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6651d6fc106a99967b4568afbbff420801363da&selectedJob=208808540

Comment 8

[Andrew Swan [:aswan]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/08ce1617c4819700220f03329bb6717dc3f20bf8
Bug 1294235 Pack xpis for addon manager tests at build time r=kmag

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/08ce1617c481