1294342 - 5.88 - 6.24% cart (windowsxp) regression on push 4e8a67e61102cb05b004fb4b9557ebb41812b9d0 (Thu Aug 4 2016)

Status: RESOLVED FIXED

(Firefox :: Untriaged, defect)

Description

[Alison Shiue]

Talos has detected a Firefox performance regression from push 4e8a67e61102cb05b004fb4b9557ebb41812b9d0. As author of one of the patches included in that push, we need your help to address this regression.

Summary of tests that regressed:

  cart summary windowsxp opt: 47.1 -> 49.87 (5.88% worse)
  cart summary windowsxp pgo: 40.77 -> 43.32 (6.24% worse)


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=2294

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the Talos jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/Buildbot/Talos/Tests

For information on reproducing and debugging the regression, either on try or locally, see: https://wiki.mozilla.org/Buildbot/Talos/Running

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Buildbot/Talos/RegressionBugsHandling

Comment 1

[Alison Shiue]

Here is the zooming better view:
https://treeherder.mozilla.org/perf.html#/graphs?series=%5Bmozilla-inbound,898b13577b15bcc31f2ea1bccc3ba5ed4533db14,1,1%5D&series=%5Bmozilla-inbound,60b82c205cac462d8ada5801ecb26d1e1fbf38d2,1,1%5D&zoom=1470264022223.355,1470422761337.3494,35,52.5&selected=%5Bmozilla-inbound,60b82c205cac462d8ada5801ecb26d1e1fbf38d2,35215,33424505,1%5D

This issue might be caused by push 4e8a67e61102.

Hi Sotaro, as you are the patch author, can you take a look at this and determine what is the root cause? Thanks!

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

I will look into backing these patches out today.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

ok, I backed this out today- :sotaro, please address this (fix, reduce, or explain) prior to relanding!

Comment 4

[Sotaro Ikeda [:sotaro]]

It was backed out by Bug 1289829 Comment 28.

Comment 5

[Sotaro Ikeda [:sotaro]]

(In reply to Joel Maher ( :jmaher) from comment #3)
> ok, I backed this out today- :sotaro, please address this (fix, reduce, or
> explain) prior to relanding!

I created a new patch attachment 8781792 [details] [diff] [review] in Bug 1289829 Comment 29. It limits the workaround only to android(MOZ_GFX_OPTIMIZE_MOBILE ).

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

thanks :sotaro, that sounds like a great solution!

Comment 7

[Gerry Chang [:gchang]]

Per comment #4, mark 51 as fixed.