Closed Bug 1294343 Opened 5 years ago Closed 5 years ago

Remove fallback-to-WARP in the compositor

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: dvander, Assigned: dvander)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Fallback-to-WARP is a little annoying to keep working with the GPU process. It's extra state to pass around everywhere, and the dynamism of it complicates decision making. We have never tested this configuration (it has shipped without any coverage, AFAIK) and it recently got disabled due to not performing well with video. WARP fallback was never more than about 1% of our D3D11 users anyway.

I'd like to just remove the fallback. For Gecko developers, we can keep a pref to force it on. Once the GPU process work has stabilized it might make sense to revisit WARP.
Attached patch patchSplinter Review
Attachment #8779973 - Flags: review?(jmuizelaar)
Comment on attachment 8779973 [details] [diff] [review]
patch

Review of attachment 8779973 [details] [diff] [review]:
-----------------------------------------------------------------

The code changes are fine with me. If you haven't already checked with Bas, you should to make sure he has no objections to removing this code.
Attachment #8779973 - Flags: review?(jmuizelaar) → review+
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d1cf3481e5f
Remove fallback to WARP, but keep the force pref for testing. (bug 1294343, r=jrmuizel)
https://hg.mozilla.org/mozilla-central/rev/8d1cf3481e5f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.