Closed Bug 1294381 Opened 8 years ago Closed 8 years ago

[e10s-multi] Web socket failure in test_bug803225.html with multiple content processes

Categories

(Core :: Networking: WebSockets, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: gkrizsanits, Unassigned)

References

Details

(Whiteboard: [e10s-multi:M1][necko-next])

Attachments

(1 file)

open() does not seem to be called on the websocket for some reason.
Blocks: e10s-multi
Whiteboard: [e10s-multi:M1]
Michal, IIRC you know websockets. Can you take a look when you get a chance?
Flags: needinfo?(michal.novotny)
Whiteboard: [e10s-multi:M1] → [e10s-multi:M1][necko-next]
After a recent update on my repo the test fails differently... Now the mailto part times out again, and the reason for it seems to be that when the webhandler opens http://example.com/tests/dom/security/test/mixedcontentblocker/file_bug803225_test_mailto.html?s=% the "content-document-global-created" observer reports https://example.com as origin instead of http://example.com. Clearing needinfo since I cannot reproduce the websocket failure anymore.
Flags: needinfo?(michal.novotny)
sigh... I forgot to enable the process script to be attached to future content processes too.
Attachment #8785180 - Flags: review?(mrbkap)
Comment on attachment 8785180 [details] [diff] [review] Delayed process script. v1 Review of attachment 8785180 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/security/test/mixedcontentblocker/file_main_bug803225.html @@ +132,5 @@ > } > } > }; > os.addObserver(observer, "content-document-global-created", false); > + }, true); Do we have to worry about this observer being attached to every following process and sending useless messages? I guess it's not that much work, so probably not.
Attachment #8785180 - Flags: review?(mrbkap) → review+
(In reply to Blake Kaplan (:mrbkap) from comment #4) > Do we have to worry about this observer being attached to every following > process and sending useless messages? I guess it's not that much work, so > probably not. Good catch. Probably it's not a huge deal but it's bothering enough, especially if people start copying it and it becomes a bad habit over time. I will try to add a removeDelayedProcessScript call in a cleanup section.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: