Closed Bug 1294384 Opened 3 years ago Closed 3 years ago

In SeekTarget class, video-only attribute should be orthogonal to the seek type

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: kaku, Assigned: kaku)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Now, we have AccurateVideoOnly SeekTarget type (http://searchfox.org/mozilla-central/source/dom/media/SeekTarget.h#27). However, applying a seek operation to video only or not should be independent to SeekTarget types( AccurateSeeek, FastSeek and NextFrameSeek). 

So, in this bug, I will remove the AccurateVideoOnly type and create a new attribute to indicate video-only.
Assignee: nobody → kaku
Blocks: 1282012
Depends on: 1294352
Comment on attachment 8780370 [details]
Bug 1294384 - make video-only attribute orthogonal to the seek type;

https://reviewboard.mozilla.org/r/71096/#review68610

::: dom/media/MediaDecoderStateMachine.cpp:1375
(Diff revision 1)
>      // Start video-only seek to the current time...
>      SeekJob seekJob;
>      seekJob.mTarget = SeekTarget(GetMediaTime(),
> -                                 SeekTarget::Type::AccurateVideoOnly,
> -                                 MediaDecoderEventVisibility::Suppressed);
> +                                 SeekTarget::Type::Accurate,
> +                                 MediaDecoderEventVisibility::Suppressed,
> +                                 true);

Say |true /* aVideoOnly */| instead to improve readability.

::: dom/media/SeekTarget.h:39
(Diff revision 1)
>    {
>    }
>    SeekTarget(int64_t aTimeUsecs,
>               Type aType,
>               MediaDecoderEventVisibility aEventVisibility =
> -               MediaDecoderEventVisibility::Observable)
> +               MediaDecoderEventVisibility::Observable,

Fix this indentation on the way.
Attachment #8780370 - Flags: review?(jwwang) → review+
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd07f10a7531
The problems in Android platform seems not related to this bug.

Thanks for the review!
Keywords: checkin-needed
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2fff8cb618fc
make video-only attribute orthogonal to the seek type; r=jwwang
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2fff8cb618fc
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.