1294463 - dom/system/gonk/AudioManager.cpp:599:62: error: 'RootingCx' is not a member of 'nsContentUtils'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=9adefc25daa8531a4bb7bbca39e39e2f1465024f&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=33716277

Comment 1

[:gerard-majax]

Attachment: Bug 1294463 - Followup 1292892, remove nsContentUtils::RootingCx()

Review commit: https://reviewboard.mozilla.org/r/70924/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70924/

Comment 2

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd669782c77f

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 8780143 [details]
Bug 1294463 - Followup 1292892, remove nsContentUtils::RootingCx()

Sorry for breaking this, but danger::GetJSContext() is not the right fix.

This should use mozilla::dom::RootingCx() instead.

Comment 4

[:gerard-majax]

Yep, I just realized that when hitting the push to try button, messed up with tabs :)

Comment 5

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ddaf1c24c381

Comment 6

[:gerard-majax]

Comment on attachment 8780143 [details]
Bug 1294463 - Followup 1292892, remove nsContentUtils::RootingCx()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/70924/diff/1-2/

Comment 7

[:gerard-majax]

Comment on attachment 8780143 [details]
Bug 1294463 - Followup 1292892, remove nsContentUtils::RootingCx()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/70924/diff/2-3/

Comment 8

[Jan de Mooij [:jandem]]

Comment on attachment 8780143 [details]
Bug 1294463 - Followup 1292892, remove nsContentUtils::RootingCx()

https://reviewboard.mozilla.org/r/70924/#review68394

Thanks!

Comment 9

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=baea526be43c

Comment 10

[:gerard-majax]

Comment on attachment 8780143 [details]
Bug 1294463 - Followup 1292892, remove nsContentUtils::RootingCx()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/70924/diff/3-4/

Comment 11

[:gerard-majax]

good to push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=baea526be43c&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=25573266

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb27f7675ebc
Followup 1292892, remove nsContentUtils::RootingCx() r=jandem

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/eb27f7675ebc