1294464 - Don't overlap inspector-search and eyedropper, pane-toggle

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P1)

Description

[magicp]

Attachment: do-not-overlap-inspector-search.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160811030201

Steps to reproduce:

1. Start Nightly
2. Open DevTools > Inspector
3. Narrow devtools-main-content


Actual results:

inspector-search overlaps eyedropper and pane-toggle.

Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=c9bbdb627b7804fee47aa6a6708647e6e589d09c&tochange=3269dd1a824d1b42cb021d1fb6858885179940b0


Expected results:

Don't overlap inspector-search and eyedropper, pane-toggle.

Comment 1

[Steve Chung [:steveck]]

Attachment: Bug 1294464 - Don't overlap inspector-search and eyedropper, pane-toggle.

Review commit: https://reviewboard.mozilla.org/r/71564/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/71564/

Comment 2

[Steve Chung [:steveck]]

A simple patch that remove the unnecessary(?) flex to the inner input div. BTW maybe we should enlarge the min-width of the devtools-main-content, otherwise the buttons at right hand side would be cut.

Comment 3

[Tim Nguyen :ntim]

Comment on attachment 8781061 [details]
Bug 1294464 - Don't overlap inspector-search and eyedropper, pane-toggle.

https://reviewboard.mozilla.org/r/71564/#review69222

LGTM!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/88bb8f11c07a
Don't overlap inspector-search and eyedropper, pane-toggle. r=ntim

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/88bb8f11c07a

Comment 6

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I did not find any issues while verifying this fix with the latest Nightly 50.0a1 using the following platforms: Ubuntu 14.04 and Max OS X 10.0.5 .

On Windows 10 x64, the problem is still reproducible using Fx51.0a1, build ID:  20160816030459. ( http://imgur.com/a/R1tT2 )

STR:
 1. Start Nightly
 2. Open DevTools > Inspector
 3. Narrow devtools-main-content
 4. Narrow the HTML panel by increasing the CSS one.

Comment 7

[Marco Mucci [:MarcoM]]

(In reply to Cristian Comorasu from comment #6)
> I did not find any issues while verifying this fix with the latest Nightly
> 50.0a1 using the following platforms: Ubuntu 14.04 and Max OS X 10.0.5 .
> 
> On Windows 10 x64, the problem is still reproducible using Fx51.0a1, build
> ID:  20160816030459. ( http://imgur.com/a/R1tT2 )
> 
> STR:
>  1. Start Nightly
>  2. Open DevTools > Inspector
>  3. Narrow devtools-main-content
>  4. Narrow the HTML panel by increasing the CSS one.

Hi Cristian, can you file a new bug for the issue you discovered and mark this bug as verified.

Comment 8

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

Hi Marco, I waited for the fix from 17 august to be available, the issue is no longer there.

However I noticed that if you follow the same steps on Aurora there is a slight overlap of the scroll bar and the code, the scroll bar seems to be semi-transparent, should I log it? ( not sure is the behavior is intended; picture of the issue: http://imgur.com/a/WL9zX )