Fix inspector textbox-search-clear position in RTL locales

VERIFIED FIXED in Firefox 51

Status

()

Firefox
Developer Tools: Inspector
P1
normal
VERIFIED FIXED
2 years ago
a year ago

People

(Reporter: magicp, Assigned: gasolin@mozilla.com)

Tracking

Trunk
Firefox 51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 unaffected, firefox51 verified)

Details

(Whiteboard: [reserve-html])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Created attachment 8780205 [details]
rtl-inspector-textbox-search-clear-position.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160811030201

Steps to reproduce:

1. Start Nightly in RTL locales
2. Open DevTools > Inspector
3. Enter any word into inspector-searchbox
4. Check textbox-search-clear position


Actual results:

textbox-search-clear position is wrong.

Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=c9bbdb627b7804fee47aa6a6708647e6e589d09c&tochange=3269dd1a824d1b42cb021d1fb6858885179940b0



Expected results:

textbox-search-clear position should be on the left side.
(Reporter)

Updated

2 years ago
Blocks: 1265759
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox50: --- → unaffected
status-firefox51: --- → affected
Component: Untriaged → Developer Tools: Inspector
OS: Unspecified → All
Hardware: Unspecified → All

Updated

2 years ago
Blocks: 1263741
Flags: qe-verify?
Whiteboard: [devtools-html] [triage]
(Assignee)

Updated

2 years ago
Assignee: nobody → gasolin
Comment hidden (mozreview-request)

Updated

2 years ago
Status: NEW → ASSIGNED
Flags: qe-verify? → qe-verify+
Priority: -- → P2
QA Contact: cristian.comorasu
Whiteboard: [devtools-html] [triage] → [reserve-html]

Comment 2

a year ago
mozreview-review
Comment on attachment 8780361 [details]
Bug 1294486 - Fix inspector textbox-search-clear position in RTL locales;

https://reviewboard.mozilla.org/r/71088/#review69232

Thanks for the patch! Please r=gl me in the commit message.
Attachment #8780361 - Flags: review?(gl) → review+

Comment 3

a year ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/76aa2e3efbdd
Fix inspector textbox-search-clear position in RTL locales; r=gl

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/76aa2e3efbdd
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Iteration: --- → 51.1 - Aug 15
Priority: P2 → P1

Comment 5

a year ago
I have reproduced this bug with Nightly 51.0a1 (2016-08-11) in RTL mode(ar) on Elementary OS 64bit. 

This bug's fix is now verified on Latest Nightly 51.0a1 in RTL mode(ar)

build id 	20160817030202
user agent	Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160817]
Status: RESOLVED → VERIFIED
Flags: qe-verify+
status-firefox51: fixed → verified
Duplicate of this bug: 1286538
You need to log in before you can comment on or make changes to this bug.