1294489 - Mochitest devtools dt9 chunk frequently last to finish on linux64 debug because of its size

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[William Lachance (:wlach)]

Looking at my infraherder prototype (http://wlach.github.io/treeherder/ui/infra.html#/last-finished), it seems like the mochitest dt9 chunk is frequently the last to finish on Linux debug.

Looking at this example:  https://treeherder.mozilla.org/#/jobs?repo=try&revision=89fccfd367377df5296d16f41b9933217e8c63f2

dt1: 44 minute(s)
dt2: 56 minute(s)
dt3: 53 minute(s)
dt4: 26 minute(s)
dt5: 63 minute(s)
dt6: 33 minute(s)
dt7: 49 minute(s)
dt8: 56 minute(s)
dt9: 83 minute(s)

It seems like reshuffling the chunks is in order. It looks like dt9 is tests in the `devtools/client/debugger/test/mochitest/` directory. :chmanchester suggested that we may need to split that up, since it's run-by-dir.

Comment 1

[Jonathan Griffin (:jgriffin)]

According to ahal, chunk-by-runtime won't split manifests, so we might be able to fix this by splitting the tests in that dir into two (or more) manifests.

We should probably re-normalize the chunks as well; it looks like this suite hasn't been touched for 11 months: https://hg.mozilla.org/mozilla-central/filelog/tip/testing/runtimes/mochitest-devtools-chrome.runtimes.json

Comment 2

[Jonathan Griffin (:jgriffin)]

Here's a try run with devtools/client/debugger/test/mochitest split into two manifests:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=359e706d089c

Runtimes on linux64 debug for all chunks are: 18, 31, 27, 20, 18, 15, 12, 18, 26, 24

So this seems to have the desired effect.

Comment 3

[Jonathan Griffin (:jgriffin)]

Attachment: Bug 1294489 - Split directory into two manifests for better chunking,

Review commit: https://reviewboard.mozilla.org/r/73860/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73860/

Comment 4

[James Long (:jlongster)]

Comment on attachment 8784397 [details]
Bug 1294489 - Split directory into two manifests for better chunking,

https://reviewboard.mozilla.org/r/73860/#review73562

Seems fine to me (sorry, was at a conference and PTO recently). It's worth noting that we are about to land a new debugger and working on an entirely new test suite, so in the next month or two we can retire these old debugger tests.

Comment 5

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8784397 [details]
Bug 1294489 - Split directory into two manifests for better chunking,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73860/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d819b0431209
Split directory into two manifests for better chunking, r=jlongster

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d819b0431209