129456 - autoreg chrome instead of using REGCHROME

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P1)

Description

[hacker formerly known as [e-mail]]

Bryner pointed out that we register the chrome when we create the jarfiles on
the mac.  We should do the same thing on unix & win32 as well. It would remove
the need for all of those @$(REGCHROME) calls from the Makefiles (removing the
need to duplicate them for the 'make install' step as well).

Comment 1

[NilsE]

*** Bug 129453 has been marked as a duplicate of this bug. ***

Comment 2

[NilsE]

*** Bug 129454 has been marked as a duplicate of this bug. ***

Comment 3

[NilsE]

*** Bug 129455 has been marked as a duplicate of this bug. ***

Comment 4

[hacker formerly known as [e-mail]]

Attachment: Update make-jars.pl to register chrome. Remove REGCHROME from Makefile.ins

Comment 5

[hacker formerly known as [e-mail]]

Attachment: Remove REGCHROME from makefile.wins

Comment 6

[hacker formerly known as [e-mail]]

Attachment: Autoregister chrome contents.rdf entries except when NO_JAR_AUTO_REG is set in the makefiles

Ok, so what I discovered is that our chrome reg isn't sync'd to the presence of
a jar file in all cases.  Specifically, all the platform locale specific jar
files under xpfe/{browser,communicator,global} do not need to be registered;
only the jar file for the current platform needs to be registered.  So I added
a NO_JAR_AUTO_REG=1 to the build to get around that problem and left the
REGCHROME entries that reference those platform specific bits in the Makefiles.
 The mac seems to get around this problem by ordering the build but since we
support parallel (-j) builds, that isn't going to work for us.

Comment 7

[hacker formerly known as [e-mail]]

Attachment: Remove REGCHROME entries from rest of Makefile.{,w}ins

Comment 8

[Brian Ryner (not reading)]

Comment on attachment 73438 [details] [diff] [review]
Autoregister chrome contents.rdf entries except when NO_JAR_AUTO_REG is set in the makefiles

r=bryner if you remove the extra \ on the first line of the RegIt function.

Comment 9

[Brian Ryner (not reading)]

Comment on attachment 73439 [details] [diff] [review]
Remove REGCHROME entries from rest of Makefile.{,w}ins

r=bryner

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 73438 [details] [diff] [review]
Autoregister chrome contents.rdf entries except when NO_JAR_AUTO_REG is set in the makefiles

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 73439 [details] [diff] [review]
Remove REGCHROME entries from rest of Makefile.{,w}ins

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 12

[hacker formerly known as [e-mail]]

Patch has been checked in.