1294577 - 1,200 instances of "NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057" emitted from dom/base/ThirdPartyUtil.cpp during linux64 debug testing

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Eric Rahm [:erahm]]

> 1196 WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file dom/base/ThirdPartyUtil.cpp, line 124

This warning [1] shows up in the following test suites:

>    156 - desktop-test-linux64/debug-mochitest-e10s-3 3
>    128 - desktop-test-linux64/debug-mochitest-3 3
>     68 - desktop-test-linux64/debug-mochitest-e10s-5 5
>     55 - desktop-test-linux64/debug-mochitest-clipboard-e10s cl
>     46 - desktop-test-linux64/debug-mochitest-2 2
>     44 - desktop-test-linux64/debug-mochitest-e10s-6 6
>     41 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
>     40 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
>     40 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
>     38 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
>     36 - desktop-test-linux64/debug-mochitest-5 5
>     36 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
>     35 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
>     28 - desktop-test-linux64/debug-mochitest-e10s-9 9
>     26 - desktop-test-linux64/debug-mochitest-e10s-4 4
>     26 - desktop-test-linux64/debug-mochitest-e10s-8 8
>     26 - desktop-test-linux64/debug-mochitest-e10s-1 1
>     26 - desktop-test-linux64/debug-mochitest-e10s-10 10
>     26 - desktop-test-linux64/debug-mochitest-e10s-7 7
>     26 - desktop-test-linux64/debug-mochitest-e10s-2 2
>     20 - desktop-test-linux64/debug-mochitest-6 6
>     20 - desktop-test-linux64/debug-mochitest-chrome-3 c3
>     18 - desktop-test-linux64/debug-mochitest-media-e10s mda
>     14 - desktop-test-linux64/debug-mochitest-clipboard cl
>     13 - desktop-test-linux64/debug-mochitest-chrome-1 c1
>     12 - desktop-test-linux64/debug-mochitest-gpu-e10s gpu
>     10 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
>     10 - desktop-test-linux64/debug-mochitest-4 4
>     10 - desktop-test-linux64/debug-mochitest-webgl-e10s gl
>      8 - desktop-test-linux64/debug-firefox-ui-functional-local-e10s en-US
>      8 - desktop-test-linux64/debug-firefox-ui-functional-remote-e10s en-US
>      6 - desktop-test-linux64/debug-mochitest-10 10
>      5 - desktop-test-linux64/debug-mochitest-chrome-2 c2
>      4 - desktop-test-linux64/debug-reftest-e10s-5 R5
>      4 - desktop-test-linux64/debug-reftest-e10s-4 R4
>      4 - desktop-test-linux64/debug-crashtest-e10s C
>      4 - desktop-test-linux64/debug-reftest-no-accel-e10s-1 Ru1
>      4 - desktop-test-linux64/debug-reftest-no-accel-e10s-8 Ru8
>      4 - desktop-test-linux64/debug-reftest-e10s-6 R6
>      4 - desktop-test-linux64/debug-reftest-no-accel-e10s-3 Ru3
>      4 - desktop-test-linux64/debug-jsreftest-e10s-1 J1
>      4 - desktop-test-linux64/debug-reftest-e10s-7 R7
>      4 - desktop-test-linux64/debug-reftest-e10s-2 R2
>      4 - desktop-test-linux64/debug-reftest-e10s-3 R3
>      4 - desktop-test-linux64/debug-reftest-no-accel-e10s-2 Ru2
>      4 - desktop-test-linux64/debug-reftest-no-accel-e10s-7 Ru7
>      4 - desktop-test-linux64/debug-reftest-no-accel-e10s-5 Ru5
>      4 - desktop-test-linux64/debug-jsreftest-e10s-2 J2
>      4 - desktop-test-linux64/debug-reftest-e10s-8 R8
>      4 - desktop-test-linux64/debug-reftest-no-accel-e10s-6 Ru6
>      4 - desktop-test-linux64/debug-reftest-e10s-1 R1
>      4 - desktop-test-linux64/debug-mochitest-browser-chrome-5 bc5
>      4 - desktop-test-linux64/debug-reftest-no-accel-e10s-4 Ru4
>      3 - desktop-test-linux64/debug-mochitest-browser-chrome-4 bc4
>      3 - desktop-test-linux64/debug-web-platform-tests-7 7
>      3 - desktop-test-linux64/debug-web-platform-tests-e10s-7 7
>      2 - desktop-test-linux64/debug-mochitest-8 8
>      2 - desktop-test-linux64/debug-mochitest-a11y a11y
>      2 - desktop-test-linux64/debug-mochitest-1 1

It shows up in 134 tests. A few of the most prevalent:

>    490 - [e10s] Shutdown
>     36 -        dom/html/test/test_iframe_sandbox_inheritance.html
>     36 - [e10s] dom/html/test/test_iframe_sandbox_inheritance.html
>     31 - [e10s] dom/html/test/test_iframe_sandbox_navigation.html
>     31 -        dom/html/test/test_iframe_sandbox_navigation.html
>     27 - [e10s] dom/html/test/test_iframe_sandbox_navigation2.html
>     27 -        dom/html/test/test_iframe_sandbox_navigation2.html
>     22 - [e10s] browser/components/sessionstore/test/browser_crashedTabs.js
>     21 -        dom/security/test/cors/test_CrossSiteXHR_origin.html
>     21 - [e10s] dom/security/test/cors/test_CrossSiteXHR_origin.html

[1] https://hg.mozilla.org/mozilla-central/annotate/0502bd9e025e/dom/base/ThirdPartyUtil.cpp#l124

Comment 1

[Eric Rahm [:erahm]]

So this is NS_ERROR_INVALID_ARG coming from |ThirdPartyUtil::GetURIFromWindow| [1], it could be from any of the return paths in there.

[1] https://hg.mozilla.org/mozilla-central/annotate/0502bd9e025e/dom/base/ThirdPartyUtil.cpp#l67

Comment 2

[Eric Rahm [:erahm]]

A lot of these are coming through |LoadInfo::ComputeIsThirdPartyContext| [1]. That appears to not be checking for failure, thus leaving |mIsThirdPartyContext| unmodified. The constructor sets it to false, so hopefully that's not a big deal.

[1] https://dxr.mozilla.org/mozilla-central/rev/0502bd9e025edde29777ba1de4280f9b52af4663/netwerk/base/LoadInfo.cpp#331-348

Comment 3

[Eric Rahm [:erahm]]

For the most part it looks like these are all due to having a null principal [1].

[1] https://dxr.mozilla.org/mozilla-central/rev/0502bd9e025edde29777ba1de4280f9b52af4663/dom/base/ThirdPartyUtil.cpp#82

Comment 4

[(no longer active)]

Windows can totally have a null principal.  We need to relax this check to not trigger a warning.

Comment 5

[(no longer active)]

Attachment: Don't issue a warning in ThirdPartyUtil::IsThirdPartyWindow when encountering a window with a null principal

Comment 6

[Eric Rahm [:erahm]]

Comment on attachment 8796290 [details] [diff] [review]
Don't issue a warning in ThirdPartyUtil::IsThirdPartyWindow when encountering a window with a null principal

Review of attachment 8796290 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the fix!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0be513c03c8
Don't issue a warning in ThirdPartyUtil::IsThirdPartyWindow when encountering a window with a null principal; r=erahm

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c0be513c03c8