1294607 - Remove redundant EnsureTarget in CanvasRenderingContext2D

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Ethan Lin[:ethlin]]

Some functions call EnsureTarget twice. I think we can remove them.

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Remove EnsureTarget.

DrawWindow and PutImageData_explicit have two EnsureTarget. I removed the second one in this patch.

Comment 2

[Ethan Lin[:ethlin]]

try server:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1bf635d98d0c

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6493296521fb
Remove unnecessary EnsureTarget in CanvasRenderingContext2D. r=nical

Comment 4

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/d0bf2598bf6a because the crashtest 1246775-1.html disagrees that it's unnecessary, https://treeherder.mozilla.org/logviewer.html#?job_id=33902610&repo=mozilla-inbound or https://treeherder.mozilla.org/logviewer.html#?job_id=33901726&repo=mozilla-inbound or https://treeherder.mozilla.org/logviewer.html#?job_id=33902162&repo=mozilla-inbound depending on which style of crashing you like best.

Comment 5

[Ethan Lin[:ethlin]]

Attachment: Remove EnsureTarget. (carry r+: nical)

I should keep the second EnsureTarget in the DrawWindows.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/44ec827b73e9
Remove unnecessary EnsureTarget in CanvasRenderingContext2D. r=nical

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/44ec827b73e9