1294645 - Don't use NS_CALLBACK for callbacks in nsI{Input,Output,UnicharInput},Stream.idl

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nicholas Nethercote [inactive]]

Slightly less than half (93 / 210) of the NS_METHOD instances in the codebase
are because of the use of NS_CALLBACK in
nsI{Input,Output,UnicharInput},Stream.idl. The use of __stdcall on Win32 isn't
important for these callbacks because they are only used as arguments to
[noscript] methods.

This patch converts them to vanilla |nsresult| functions. It increases the size
of xul.dll by about ~600 bytes, which is about 0.001%.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Don't use NS_CALLBACK for callbacks in nsI{Input,Output,UnicharInput},Stream.idl

Comment 2

[Nicholas Nethercote [inactive]]

Try's looking good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7464e5386229

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8780414 [details] [diff] [review]
Don't use NS_CALLBACK for callbacks in nsI{Input,Output,UnicharInput},Stream.idl

Review of attachment 8780414 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for including the size comparison. :)  One less thing to think about when using these classes and callbacks--which always confuse me.

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/360df5276cf6e2d7294ce0e122952cf56bc5372e
Bug 1294645 - Don't use NS_CALLBACK for callbacks in nsI{Input,Output,UnicharInput},Stream.idl. r=froydnj.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/360df5276cf6